-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: archive state using BufferPool if provided #7042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7042 +/- ##
============================================
- Coverage 49.25% 49.24% -0.01%
============================================
Files 578 578
Lines 37443 37441 -2
Branches 2172 2171 -1
============================================
- Hits 18441 18439 -2
+ Misses 18962 18961 -1
- Partials 40 41 +1 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Sep 3, 2024
philknows
pushed a commit
that referenced
this pull request
Sep 11, 2024
* fix: archive state using BufferPool if provided * chore: fix comment
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
BufferPool
to have metric labels based on sourceBufferPool
on BeaconChain based on n-historical flagserializeState()
apiserializeState()
apiFollow up
serializeState.ts
andinitState.ts
to newchain/states
if we want toCloses #6935
cc @nazarhussain