style: enable all biomejs recommended rules

biome.jsonc

@@ -191,9 +191,9 @@
         "useAsConstAssertion": "error"
       },
       "suspicious": {
+        // `void` as type is useful in our case when used as generic constraint e.g. K extends number | void
         "noConfusingVoidType": "off",
         "noConsoleLog": "error",
-        "noDoubleEquals": "off",
         "noDuplicateTestHooks": "off",
         "noExplicitAny": "error",
         "noExportsInTest": "off",

packages/api/test/utils/utils.ts

@@ -21,7 +21,7 @@ export function getTestServer(): {server: FastifyInstance; start: () => Promise<
   const start = (): Promise<string> =>
     new Promise<string>((resolve, reject) => {
       server.listen({port: 0}, function (err, address) {
-        if (err !== null && err != undefined) {
+        if (err !== null && err !== undefined) {
           reject(err);
         } else {
           resolve(address);

packages/beacon-node/src/chain/balancesCache.ts

@@ -35,7 +35,7 @@ export class CheckpointBalancesCache {
     const epochBoundaryRoot =
       epochBoundarySlot === state.slot ? blockRootHex : toRootHex(getBlockRootAtSlot(state, epochBoundarySlot));
 
-    const index = this.items.findIndex((item) => item.epoch === epoch && item.rootHex == epochBoundaryRoot);
+    const index = this.items.findIndex((item) => item.epoch === epoch && item.rootHex === epochBoundaryRoot);
     if (index === -1) {
       if (this.items.length === MAX_BALANCE_CACHE_SIZE) {
         this.items.shift();

packages/beacon-node/src/chain/blocks/writeBlockInputToDb.ts

@@ -31,7 +31,7 @@ export async function writeBlockInputToDb(this: BeaconChain, blocksInput: BlockI
 
     if (blockInput.type === BlockInputType.availableData || blockInput.type === BlockInputType.dataPromise) {
       const blobSidecars =
-        blockInput.type == BlockInputType.availableData
+        blockInput.type === BlockInputType.availableData
           ? blockInput.blockData.blobs
           : // At this point of import blobs are available and can be safely awaited
             (await blockInput.cachedData.availabilityPromise).blobs;

packages/beacon-node/src/chain/lightClient/index.ts

@@ -635,7 +635,7 @@ export class LightClientServer {
     if (
       attestedData.isFinalized &&
       finalizedHeaderAttested &&
-      computeSyncPeriodAtSlot(finalizedHeaderAttested.beacon.slot) == syncPeriod
+      computeSyncPeriodAtSlot(finalizedHeaderAttested.beacon.slot) === syncPeriod
     ) {
       isFinalized = true;
       finalityBranch = attestedData.finalityBranch;

packages/beacon-node/src/db/buckets.ts

@@ -66,7 +66,7 @@ export enum Bucket {
 export function getBucketNameByValue<T extends Bucket>(enumValue: T): keyof typeof Bucket {
   const keys = Object.keys(Bucket).filter((x) => {
     if (isNaN(parseInt(x))) {
-      return Bucket[x as keyof typeof Bucket] == enumValue;
+      return Bucket[x as keyof typeof Bucket] === enumValue;
     } else {
       return false;
     }

packages/beacon-node/src/eth1/eth1MergeBlockTracker.ts

@@ -193,7 +193,7 @@ export class Eth1MergeBlockTracker {
           // Persist found merge block here to affect both caller paths:
           // - internal searcher
           // - external caller if STOPPED
-          if (mergeBlock && this.status.code != StatusCode.FOUND) {
+          if (mergeBlock && this.status.code !== StatusCode.FOUND) {
             if (this.status.code === StatusCode.SEARCHING) {
               this.close();
             }

packages/beacon-node/src/network/reqresp/types.ts

@@ -99,7 +99,7 @@ export const responseSszTypeByMethod: {[K in ReqRespMethod]: ResponseTypeGetter<
   [ReqRespMethod.Status]: () => ssz.phase0.Status,
   [ReqRespMethod.Goodbye]: () => ssz.phase0.Goodbye,
   [ReqRespMethod.Ping]: () => ssz.phase0.Ping,
-  [ReqRespMethod.Metadata]: (_, version) => (version == Version.V1 ? ssz.phase0.Metadata : ssz.altair.Metadata),
+  [ReqRespMethod.Metadata]: (_, version) => (version === Version.V1 ? ssz.phase0.Metadata : ssz.altair.Metadata),
   [ReqRespMethod.BeaconBlocksByRange]: blocksResponseType,
   [ReqRespMethod.BeaconBlocksByRoot]: blocksResponseType,
   [ReqRespMethod.BlobSidecarsByRange]: () => ssz.deneb.BlobSidecar,

packages/beacon-node/src/sync/utils/remoteSyncType.ts

@@ -53,7 +53,7 @@ export function getPeerSyncType(
   else if (remote.finalizedEpoch > local.finalizedEpoch) {
     if (
       // Peer is in next epoch, and head is within range => SYNCED
-      (local.finalizedEpoch + 1 == remote.finalizedEpoch &&
+      (local.finalizedEpoch + 1 === remote.finalizedEpoch &&
         withinRangeOf(remote.headSlot, local.headSlot, slotImportTolerance)) ||
       // Peer's head is known => SYNCED
       forkChoice.hasBlock(remote.headRoot)

packages/beacon-node/src/util/binarySearch.ts

@@ -1,5 +1,5 @@
 export function binarySearchLte<T>(items: T[], value: number, getter: (item: T) => number): T {
-  if (items.length == 0) {
+  if (items.length === 0) {
     throw new ErrorNoValues();
   }
 

packages/beacon-node/test/unit/util/array.test.ts

@@ -3,13 +3,13 @@ import {findLastIndex, LinkedList} from "../../../src/util/array.js";
 
 describe("findLastIndex", () => {
   it("should return the last index that matches a predicate", () => {
-    expect(findLastIndex([1, 2, 3, 4], (n) => n % 2 == 0)).toEqual(3);
-    expect(findLastIndex([1, 2, 3, 4, 5], (n) => n % 2 == 0)).toEqual(3);
+    expect(findLastIndex([1, 2, 3, 4], (n) => n % 2 === 0)).toEqual(3);
+    expect(findLastIndex([1, 2, 3, 4, 5], (n) => n % 2 === 0)).toEqual(3);
     expect(findLastIndex([1, 2, 3, 4, 5], () => true)).toEqual(4);
   });
 
   it("should return -1 if there are no matches", () => {
-    expect(findLastIndex([1, 3, 5], (n) => n % 2 == 0)).toEqual(-1);
+    expect(findLastIndex([1, 3, 5], (n) => n % 2 === 0)).toEqual(-1);
     expect(findLastIndex([1, 2, 3, 4, 5], () => false)).toEqual(-1);
   });
 });

packages/cli/src/util/jwt.ts

@@ -2,7 +2,7 @@ export function extractJwtHexSecret(jwtSecretContents: string): string {
   const hexPattern = new RegExp(/^(0x|0X)?(?<jwtSecret>[a-fA-F0-9]+)$/, "g");
   const jwtSecretHexMatch = hexPattern.exec(jwtSecretContents);
   const jwtSecret = jwtSecretHexMatch?.groups?.jwtSecret;
-  if (!jwtSecret || jwtSecret.length != 64) {
+  if (!jwtSecret || jwtSecret.length !== 64) {
     throw Error(`Need a valid 256 bit hex encoded secret ${jwtSecret} ${jwtSecretContents}`);
   }
   // Return the secret in proper hex format

packages/cli/test/utils/crucible/assertions/nodeAssertion.ts

@@ -17,7 +17,7 @@ export const nodeAssertion: Assertion<"node", {health: number; keyManagerKeys: s
 
     let keyManagerKeys: string[];
     // There is an authentication issue with the lighthouse keymanager client
-    if (node.validator.client == ValidatorClient.Lighthouse || getAllKeys(node.validator.keys).length === 0) {
+    if (node.validator.client === ValidatorClient.Lighthouse || getAllKeys(node.validator.keys).length === 0) {
       keyManagerKeys = [];
     } else {
       const keys = (await node.validator.keyManager.listKeys()).value();
@@ -30,7 +30,7 @@ export const nodeAssertion: Assertion<"node", {health: number; keyManagerKeys: s
     const errors: AssertionResult[] = [];
 
     // There is an authentication issue with the lighthouse keymanager client
-    if (node.validator?.client == ValidatorClient.Lighthouse) return errors;
+    if (node.validator?.client === ValidatorClient.Lighthouse) return errors;
 
     const {health, keyManagerKeys} = store[slot];
 

packages/cli/test/utils/crucible/clients/execution/geth.ts

@@ -145,7 +145,7 @@ export const generateGethNode: ExecutionNodeGenerator<ExecutionClient.Geth> = (o
         "--verbosity",
         "5",
         ...(mining ? ["--mine", "--miner.etherbase", EL_GENESIS_ACCOUNT] : []),
-        ...(mode == ExecutionStartMode.PreMerge ? ["--nodiscover"] : []),
+        ...(mode === ExecutionStartMode.PreMerge ? ["--nodiscover"] : []),
         ...clientOptions,
       ],
       env: {},

packages/light-client/src/spec/isBetterUpdate.ts

@@ -28,49 +28,49 @@ export function isBetterUpdate(newUpdate: LightClientUpdateSummary, oldUpdate: L
   const oldNumActiveParticipants = oldUpdate.activeParticipants;
   const newHasSupermajority = newNumActiveParticipants * 3 >= SYNC_COMMITTEE_SIZE * 2;
   const oldHasSupermajority = oldNumActiveParticipants * 3 >= SYNC_COMMITTEE_SIZE * 2;
-  if (newHasSupermajority != oldHasSupermajority) {
+  if (newHasSupermajority !== oldHasSupermajority) {
     return newHasSupermajority;
   }
-  if (!newHasSupermajority && newNumActiveParticipants != oldNumActiveParticipants) {
+  if (!newHasSupermajority && newNumActiveParticipants !== oldNumActiveParticipants) {
     return newNumActiveParticipants > oldNumActiveParticipants;
   }
 
   // Compare presence of relevant sync committee
   const newHasRelevantSyncCommittee =
     newUpdate.isSyncCommitteeUpdate &&
-    computeSyncPeriodAtSlot(newUpdate.attestedHeaderSlot) == computeSyncPeriodAtSlot(newUpdate.signatureSlot);
+    computeSyncPeriodAtSlot(newUpdate.attestedHeaderSlot) === computeSyncPeriodAtSlot(newUpdate.signatureSlot);
   const oldHasRelevantSyncCommittee =
     oldUpdate.isSyncCommitteeUpdate &&
-    computeSyncPeriodAtSlot(oldUpdate.attestedHeaderSlot) == computeSyncPeriodAtSlot(oldUpdate.signatureSlot);
-  if (newHasRelevantSyncCommittee != oldHasRelevantSyncCommittee) {
+    computeSyncPeriodAtSlot(oldUpdate.attestedHeaderSlot) === computeSyncPeriodAtSlot(oldUpdate.signatureSlot);
+  if (newHasRelevantSyncCommittee !== oldHasRelevantSyncCommittee) {
     return newHasRelevantSyncCommittee;
   }
 
   // Compare indication of any finality
   const newHasFinality = newUpdate.isFinalityUpdate;
   const oldHasFinality = oldUpdate.isFinalityUpdate;
-  if (newHasFinality != oldHasFinality) {
+  if (newHasFinality !== oldHasFinality) {
     return newHasFinality;
   }
 
   // Compare sync committee finality
   if (newHasFinality) {
     const newHasSyncCommitteeFinality =
-      computeSyncPeriodAtSlot(newUpdate.finalizedHeaderSlot) == computeSyncPeriodAtSlot(newUpdate.attestedHeaderSlot);
+      computeSyncPeriodAtSlot(newUpdate.finalizedHeaderSlot) === computeSyncPeriodAtSlot(newUpdate.attestedHeaderSlot);
     const oldHasSyncCommitteeFinality =
-      computeSyncPeriodAtSlot(oldUpdate.finalizedHeaderSlot) == computeSyncPeriodAtSlot(oldUpdate.attestedHeaderSlot);
-    if (newHasSyncCommitteeFinality != oldHasSyncCommitteeFinality) {
+      computeSyncPeriodAtSlot(oldUpdate.finalizedHeaderSlot) === computeSyncPeriodAtSlot(oldUpdate.attestedHeaderSlot);
+    if (newHasSyncCommitteeFinality !== oldHasSyncCommitteeFinality) {
       return newHasSyncCommitteeFinality;
     }
   }
 
   // Tiebreaker 1: Sync committee participation beyond supermajority
-  if (newNumActiveParticipants != oldNumActiveParticipants) {
+  if (newNumActiveParticipants !== oldNumActiveParticipants) {
     return newNumActiveParticipants > oldNumActiveParticipants;
   }
 
   // Tiebreaker 2: Prefer older data (fewer changes to best)
-  if (newUpdate.attestedHeaderSlot != oldUpdate.attestedHeaderSlot) {
+  if (newUpdate.attestedHeaderSlot !== oldUpdate.attestedHeaderSlot) {
     return newUpdate.attestedHeaderSlot < oldUpdate.attestedHeaderSlot;
   }
   return newUpdate.signatureSlot < oldUpdate.signatureSlot;

packages/prover/src/web3_provider_inspector.ts

@@ -68,7 +68,7 @@ export class Web3ProviderInspector {
       return;
     }
 
-    const index = this.providerTypes.findIndex((p) => p.name == indexOrName);
+    const index = this.providerTypes.findIndex((p) => p.name === indexOrName);
     if (index < 0) {
       throw Error(`Provider type '${indexOrName}' is not registered.`);
     }

packages/state-transition/src/util/shuffle.ts

@@ -81,7 +81,7 @@ function innerShuffleList(input: Shuffleable, seed: Bytes32, dir: boolean): void
     // nothing to (un)shuffle
     return;
   }
-  if (SHUFFLE_ROUND_COUNT == 0) {
+  if (SHUFFLE_ROUND_COUNT === 0) {
     // no shuffling
     return;
   }
@@ -145,20 +145,20 @@ function innerShuffleList(input: Shuffleable, seed: Bytes32, dir: boolean): void
       // -- step() fn start
       // The pair is i,j. With j being the bigger of the two, hence the "position" identifier of the pair.
       // Every 256th bit (aligned to j).
-      if ((j & 0xff) == 0xff) {
+      if ((j & 0xff) === 0xff) {
         // just overwrite the last part of the buffer, reuse the start (seed, round)
         setPositionUint32(j >> 8, buf);
         source = digest(buf);
       }
 
       // Same trick with byte retrieval. Only every 8th.
-      if ((j & 0x7) == 0x7) {
+      if ((j & 0x7) === 0x7) {
         byteV = source[(j & 0xff) >> 3];
       }
 
       const bitV = (byteV >> (j & 0x7)) & 0x1;
 
-      if (bitV == 1) {
+      if (bitV === 1) {
         // swap the pair items
         const tmp = input[j];
         input[j] = input[i];
@@ -181,20 +181,20 @@ function innerShuffleList(input: Shuffleable, seed: Bytes32, dir: boolean): void
       // -- step() fn start
       // The pair is i,j. With j being the bigger of the two, hence the "position" identifier of the pair.
       // Every 256th bit (aligned to j).
-      if ((j & 0xff) == 0xff) {
+      if ((j & 0xff) === 0xff) {
         // just overwrite the last part of the buffer, reuse the start (seed, round)
         setPositionUint32(j >> 8, buf);
         source = digest(buf);
       }
 
       // Same trick with byte retrieval. Only every 8th.
-      if ((j & 0x7) == 0x7) {
+      if ((j & 0x7) === 0x7) {
         byteV = source[(j & 0xff) >> 3];
       }
 
       const bitV = (byteV >> (j & 0x7)) & 0x1;
 
-      if (bitV == 1) {
+      if (bitV === 1) {
         // swap the pair items
         const tmp = input[j];
         input[j] = input[i];
@@ -207,11 +207,11 @@ function innerShuffleList(input: Shuffleable, seed: Bytes32, dir: boolean): void
     if (dir) {
       // -> shuffle
       r += 1;
-      if (r == SHUFFLE_ROUND_COUNT) {
+      if (r === SHUFFLE_ROUND_COUNT) {
         break;
       }
     } else {
-      if (r == 0) {
+      if (r === 0) {
         break;
       }
       // -> un-shuffle

packages/state-transition/src/util/shufflingDecisionRoot.ts

@@ -12,7 +12,7 @@ import {computeStartSlotAtEpoch} from "./epoch.js";
  */
 export function proposerShufflingDecisionRoot(state: CachedBeaconStateAllForks): Root | null {
   const decisionSlot = proposerShufflingDecisionSlot(state);
-  if (state.slot == decisionSlot) {
+  if (state.slot === decisionSlot) {
     return null;
   } else {
     return getBlockRootAtSlot(state, decisionSlot);
@@ -37,7 +37,7 @@ function proposerShufflingDecisionSlot(state: CachedBeaconStateAllForks): Slot {
  */
 export function attesterShufflingDecisionRoot(state: CachedBeaconStateAllForks, requestedEpoch: Epoch): Root | null {
   const decisionSlot = attesterShufflingDecisionSlot(state, requestedEpoch);
-  if (state.slot == decisionSlot) {
+  if (state.slot === decisionSlot) {
     return null;
   } else {
     return getBlockRootAtSlot(state, decisionSlot);

packages/state-transition/test/perf/shuffle/numberMath.test.ts

@@ -30,7 +30,7 @@ describe.skip("shuffle number math ops", () => {
 
   itBench("i == j", () => {
     for (let i = 0; i < forRuns; i++) {
-      i == j;
+      i === j;
     }
   });
 
@@ -42,13 +42,13 @@ describe.skip("shuffle number math ops", () => {
 
   itBench("bit opts", () => {
     for (let i = 0; i < forRuns; i++) {
-      (j & 0x7) == 0x7;
+      (j & 0x7) === 0x7;
     }
   });
 
   itBench("modulo", () => {
     for (let i = 0; i < forRuns; i++) {
-      j % 8 == 0;
+      j % 8 === 0;
     }
   });
 

packages/validator/src/buckets.ts

@@ -18,7 +18,7 @@ export enum Bucket {
 export function getBucketNameByValue<T extends Bucket>(enumValue: T): keyof typeof Bucket {
   const keys = Object.keys(Bucket).filter((x) => {
     if (isNaN(parseInt(x))) {
-      return Bucket[x as keyof typeof Bucket] == enumValue;
+      return Bucket[x as keyof typeof Bucket] === enumValue;
     } else {
       return false;
     }

packages/validator/src/services/validatorStore.ts

@@ -805,7 +805,7 @@ export class ValidatorStore {
     }
 
     const isPostElectra = this.config.getForkSeq(data.slot) >= ForkSeq.electra;
-    if (!isPostElectra && duty.committeeIndex != data.index) {
+    if (!isPostElectra && duty.committeeIndex !== data.index) {
       throw Error(
         `Inconsistent duties during signing: duty.committeeIndex ${duty.committeeIndex} != att.committeeIndex ${data.index}`
       );

packages/validator/src/slashingProtection/attestation/index.ts

@@ -39,7 +39,7 @@ export class SlashingProtectionAttestationService {
   async checkAndInsertAttestation(pubKey: BLSPubkey, attestation: SlashingProtectionAttestation): Promise<void> {
     const safeStatus = await this.checkAttestation(pubKey, attestation);
 
-    if (safeStatus != SafeStatus.SAME_DATA) {
+    if (safeStatus !== SafeStatus.SAME_DATA) {
       await this.insertAttestation(pubKey, attestation);
     }
 

packages/validator/src/slashingProtection/block/index.ts

@@ -24,7 +24,7 @@ export class SlashingProtectionBlockService {
   async checkAndInsertBlockProposal(pubkey: BLSPubkey, block: SlashingProtectionBlock): Promise<void> {
     const safeStatus = await this.checkBlockProposal(pubkey, block);
 
-    if (safeStatus != SafeStatus.SAME_DATA) {
+    if (safeStatus !== SafeStatus.SAME_DATA) {
       await this.insertBlockProposal(pubkey, block);
     }