feat: add strategy support for state archives #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
commented
Oct 16, 2024
| @@ -0,0 +1,163 @@ | |||
| import {Logger} from "@lodestar/utils"; | |||
There was a problem hiding this comment.
This file is actually old index.ts file, with only strategy specific changes.
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
commented
Oct 17, 2024
| import {RootHex} from "@lodestar/types"; | ||
|
|
||
| export enum ArchiveMode { | ||
| Full = "full", |
There was a problem hiding this comment.
If you think of a better name for current archiver strategy we use, please suggest.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7170 +/- ##
============================================
- Coverage 49.21% 49.19% -0.02%
============================================
Files 598 598
Lines 39726 39779 +53
Branches 2093 2097 +4
============================================
+ Hits 19551 19570 +19
- Misses 20135 20169 +34
Partials 40 40 |
nflaig
reviewed
Oct 17, 2024
| import {RootHex} from "@lodestar/types"; | ||
|
|
||
| export enum ArchiveMode { | ||
| Full = "full", |
There was a problem hiding this comment.
More of a general question, once we have differential archive mode implemented, will there be any advantage to use our current (full) archiving strategy?
If not, we should probably not make it overly generic / switchable
There was a problem hiding this comment.
My idea is to get the differential strategy released as experimental first. As I am a bit skeptical about it's memory implication. So during that time user can choose which strategy to use.
twoeths
reviewed
Oct 21, 2024
twoeths
reviewed
Oct 21, 2024
packages/beacon-node/src/chain/archiver/strategies/frequencyStateArchiveStrategy.ts
Outdated
Show resolved
Hide resolved
twoeths
reviewed
Oct 21, 2024
| @@ -0,0 +1,46 @@ | |||
| import {CheckpointWithHex} from "@lodestar/fork-choice"; | |||
| import {Metrics} from "../../metrics/metrics.js"; | |||
| import {RootHex} from "@lodestar/types"; | |||
There was a problem hiding this comment.
the new linter does not enforce import order anymore?
There was a problem hiding this comment.
There is a caveat related to import order, not yet enabled. #7182
twoeths
reviewed
Oct 21, 2024
twoeths
reviewed
Oct 21, 2024
twoeths
reviewed
Oct 21, 2024
twoeths
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the state-archive process more generic so we can extend in future.
Description
Steps to test or reproduce