-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update block proposal errors dashboard panel #7179
Conversation
@@ -499,7 +499,6 @@ export function getDefinitions(config: ChainForkConfig): RouteDefinitions<Endpoi | |||
const fork = config.getForkName(signedBlindedBlock.message.slot); | |||
return { | |||
body: getExecutionForkTypes(fork).SignedBlindedBeaconBlock.toJson(signedBlindedBlock), | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated but might as well fix formatting here
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7179 +/- ##
=========================================
Coverage 49.18% 49.18%
=========================================
Files 598 598
Lines 39770 39770
Branches 2092 2092
=========================================
Hits 19560 19560
Misses 20170 20170
Partials 40 40 |
Performance Report✔️ no performance regression detected Full benchmark results
|
@nflaig would be great to fix broken "Lodestar - block production" panel "Success + Error" rates, labels are duplicated |
There are also "dead" panels as we have removed metrics for some of the panels, e.g. all the 3 empty panels here We have added a different metrics for submitted block proposals in validator monitor which we can use to replace those, also wanna take a look at the local vs. builder %, I thought we had a panel but does not seem to be the case, also noted here #6108 that it did not work as expected |
Update
operationId
in block proposal errors dashboard panel to use latest version of apis as previous (deprecated) apis are unused in Lodestar by default (and soon to be removed).