-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: log as info instead of warn if builder does not provide a bid #7191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
previously approved these changes
Oct 22, 2024
wemeetagain
approved these changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7191 +/- ##
============================================
- Coverage 49.21% 49.21% -0.01%
============================================
Files 598 598
Lines 39794 39794
Branches 2093 2087 -6
============================================
- Hits 19584 19583 -1
- Misses 20170 20171 +1
Partials 40 40 |
Performance Report✔️ no performance regression detected Full benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We previously had a really bad JSON parse error which created too much noise if builder didn't provide a bid but since the api client refactor we can handle this case properly but we still log it as a
warn
currently if builder does not provide a bid. While I think it's not as bad as it was, after further discussion and input in #6574 I think it's reasonable to just log it asinfo
and create less noise (no stacktrace).Description
Log as
info
instead ofwarn
if builder does not provide a bidCloses #6574