Migrate to napi-rs implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
approved these changes
Sep 26, 2024
Update the docker for build ci Update the docker image Remove docker from musl build Remove docker from musl build Update build command Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Add a package to docker container Revert CI to use the docker based build Fix a typo Fix a typo Fix cargo config Enable cross compile build Update the config Add debug flag Add multilib package Add multilib package Add multilib package Refactor CI pipeline Refactor CI pipeline Update dependencies Add rustup support Add rustup support Add musl target Debug stdlib file Search for multilib packages Add old multilib packages Add cargo flag Add libclang-dev Add libclang-dev Update the cargo tasks Update the build script Run CI without cache Use required packages Use latest napi for cross compile Use latest napi for cross compile Update CI pipeline
nazarhussain
force-pushed
the
nh/napi-rs
branch
from
ff1e89f
to
428116d
Compare
nazarhussain
force-pushed
the
nh/napi-rs
branch
5 times, most recently
from
50f53e0
to
27b0f08
Compare
nazarhussain
force-pushed
the
nh/napi-rs
branch
from
27b0f08
to
ba1737d
Compare
wemeetagain
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion, we decided to stick with the
napi-rs, as the whole team have more knowledge and comfort level with the Rust.