-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing directly from GH #1423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokterbob
changed the title
Dokterbob/build frontend on poetry build
Allow installing directly from GH
Oct 10, 2024
dokterbob
force-pushed
the
dokterbob/build_frontend_on_poetry_build
branch
2 times, most recently
from
October 10, 2024 15:27
2bb859e
to
891c123
Compare
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Oct 10, 2024
dosubot
bot
added
backend
Pertains to the Python backend.
dev-tooling
Relating to developer/contributor toolings.
frontend
Pertains to the frontend.
labels
Oct 10, 2024
dokterbob
force-pushed
the
dokterbob/build_frontend_on_poetry_build
branch
from
October 15, 2024 10:59
891c123
to
8d19f05
Compare
willydouhard
approved these changes
Oct 17, 2024
dokterbob
force-pushed
the
dokterbob/build_frontend_on_poetry_build
branch
from
October 17, 2024 11:16
8d19f05
to
410cb05
Compare
* No need to copy already symlinked README. * Help Windows find pnpm. Ref: https://stackoverflow.com/questions/3022013/windows-cant-find-the-file-on-subprocess-call
* Remove empty README in backend. * Move README.md to backend dir. * Add README.md back to root as symlink.
dokterbob
force-pushed
the
dokterbob/build_frontend_on_poetry_build
branch
from
October 17, 2024 11:18
410cb05
to
6f6a0b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Pertains to the Python backend.
dev-tooling
Relating to developer/contributor toolings.
frontend
Pertains to the frontend.
review-me
Ready for review!
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it much, much easier to develop and/or test branches, allows specifying a fork or branch as install dependency.
Tackles #1224.
Tested to work with poetry and pip in virtualenv.
Test with
poetry add git+https://github.com/Chainlit/chainlit.git@dokterbob/build_frontend_on_poetry_build#subdirectory=backend
and/orpip install git+https://github.com/Chainlit/chainlit.git@dokterbob/build_frontend_on_poetry_build#subdirectory=backend
.Both confirmed to work with
-e
option.