Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing directly from GH #1423

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

dokterbob
Copy link
Collaborator

@dokterbob dokterbob commented Oct 10, 2024

Makes it much, much easier to develop and/or test branches, allows specifying a fork or branch as install dependency.

Tackles #1224.

Tested to work with poetry and pip in virtualenv.

Test with poetry add git+https://github.com/Chainlit/chainlit.git@dokterbob/build_frontend_on_poetry_build#subdirectory=backend and/or pip install git+https://github.com/Chainlit/chainlit.git@dokterbob/build_frontend_on_poetry_build#subdirectory=backend.

Both confirmed to work with -e option.

@dokterbob dokterbob changed the title Dokterbob/build frontend on poetry build Allow installing directly from GH Oct 10, 2024
@dokterbob dokterbob force-pushed the dokterbob/build_frontend_on_poetry_build branch 2 times, most recently from 2bb859e to 891c123 Compare October 10, 2024 15:27
@dokterbob dokterbob marked this pull request as ready for review October 10, 2024 15:45
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 10, 2024
@dosubot dosubot bot added backend Pertains to the Python backend. dev-tooling Relating to developer/contributor toolings. frontend Pertains to the frontend. labels Oct 10, 2024
@dokterbob dokterbob added the review-me Ready for review! label Oct 10, 2024
@dokterbob dokterbob force-pushed the dokterbob/build_frontend_on_poetry_build branch from 891c123 to 8d19f05 Compare October 15, 2024 10:59
@dokterbob dokterbob force-pushed the dokterbob/build_frontend_on_poetry_build branch from 8d19f05 to 410cb05 Compare October 17, 2024 11:16
@dokterbob dokterbob force-pushed the dokterbob/build_frontend_on_poetry_build branch from 410cb05 to 6f6a0b5 Compare October 17, 2024 11:18
@dokterbob dokterbob merged commit b6729bb into main Oct 17, 2024
15 checks passed
@dokterbob dokterbob deleted the dokterbob/build_frontend_on_poetry_build branch October 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Pertains to the Python backend. dev-tooling Relating to developer/contributor toolings. frontend Pertains to the frontend. review-me Ready for review! size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants