Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1230 Incorrect message ordering in UI #1501

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

pmercier
Copy link
Contributor

@pmercier pmercier commented Nov 5, 2024

AskUserMessage answer was added in frontend message memory without parentId resulting in wrongly ordered messages.

Detail in #1230

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working frontend Pertains to the frontend. labels Nov 5, 2024
@pmercier pmercier marked this pull request as draft November 5, 2024 15:28
@pmercier pmercier marked this pull request as ready for review November 5, 2024 15:40
Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the extensive bug description and testing in #1230!

@dokterbob dokterbob merged commit 2ba2c59 into Chainlit:main Nov 6, 2024
17 checks passed
@gcleaves
Copy link
Contributor

gcleaves commented Nov 6, 2024

Thanks pmercier and dokterbob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Pertains to the frontend. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants