Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth_providers.py to include Keycloak #1525

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

gcleaves
Copy link
Contributor

Added Keycloak OAuthProvider.

Please let me know how to submit a pull request for the docs, I found nothing in the Contributing guidelines.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auth Pertaining to authentication. backend Pertains to the Python backend. labels Nov 17, 2024
@gcleaves
Copy link
Contributor Author

gcleaves commented Nov 19, 2024

Hi. Can @dokterbob or @willydouhard guide me on what I need to do to fix this lint-backend error.

@dokterbob
Copy link
Collaborator

Details

Error: backend/chainlit/oauth_providers.py:1:1: I001 Import block is un-sorted or un-formatted

You can use ruff check --fix backend/chainlit/oauth_providers.py to automagically sort imports although I would actually recommend you configure your editor to use ruff.

@gcleaves
Copy link
Contributor Author

I've used ruff as instructed (to 'fix' somebody else's code :) .

@dokterbob
Copy link
Collaborator

I've used ruff as instructed (to 'fix' somebody else's code :) .

Yeah I'm sorry, this was supposed to happen automagically in the commit hook, which was broken. ;)

Your error caught me onto it and it's fixed on main now.

@dokterbob dokterbob closed this Nov 25, 2024
@dokterbob dokterbob reopened this Nov 25, 2024
Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Appreciate your patience.

@dokterbob dokterbob merged commit 8e739b3 into Chainlit:main Nov 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Pertaining to authentication. backend Pertains to the Python backend. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants