Revert "feat: chainlit option to require websocket" #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlit#1379)" This reverts commit 00f96b8.
dosubot
bot
added
the
size:M
dokterbob
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Sure, this is why we do release candidates. 😅
Thanks for catching this before we release. Indeed, let's have tests.
Would you be able to replicate the issue your experiencing in an E2E or unit test with #1379? We can then use that regression test that a future patch won't contain it.
Also, a PR to remove the feature from the 2.0 changelog would be an amazing help! If not, I'll do it on release.
sandangel
deleted the
revert-1379-fix/chainlit-upgrade-websocket-retry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1379
This is not working as intended. There are some race condition between events that we are subcribing to. So just revert and then we can implement a proper PR with tests.