Make callbacks available at the main module level again, but lazily #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnes
force-pushed
the
gg/module-getattr
branch
2 times, most recently
from
473b236
to
5e7719c
Compare
This keeps the imports fast, but with a few advantages over the current implementation: 1. we don't introduce a breaking change to the end users; 2. it's easier to import `chainlit` once and getting all things from there; 3. doing so also makes it easier to read the code and understand what comes from chainlit: `cl.LangchainCallbackHandler` makes it obvious that it's Chainlit's callback handler for Langchain (as opposed to `LangchainCallbackHandler`, without `cl.` in front).
ramnes
force-pushed
the
gg/module-getattr
branch
from
5e7719c
to
2963180
Compare
willydouhard
approved these changes
Aug 15, 2023
| @@ -181,6 +181,15 @@ def sleep(duration: int): | |||
| return asyncio.sleep(duration) | |||
|
|
|||
|
|
|||
| __getattr__ = make_module_getattr( | |||
| { | |||
There was a problem hiding this comment.
Sorry I'm new in python, I wonder why not just import the handlers like this:
from chainlit.langchain.callbacks import LangchainCallbackHandler, AsyncLangchainCallbackHandler, LlamaIndexCallbackHandler, HaystackAgentCallbackHandlerDoes it has any advantages I didn't know?
There was a problem hiding this comment.
This would be working fine but would also import the Langchain library by default, which we want to avoid for performance reasons. This PR will make the Langchain (and other libraries) imports lazy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the imports fast, but with a few advantages over the current implementation:
chainlitonce and getting all things from there;cl.LangchainCallbackHandlermakes it obvious that it's Chainlit's callback handler for Langchain (as opposed toLangchainCallbackHandler, withoutcl.in front).