Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare versions with packaging.version #332

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Compare versions with packaging.version #332

merged 2 commits into from
Aug 28, 2023

Conversation

xsyann
Copy link
Contributor

@xsyann xsyann commented Aug 28, 2023

Fix version comparison from string compare to PEP 440 versions.
packaging.version is used instead of semver because semver doesn't support version like 0.8.11.post3

@xsyann xsyann requested a review from willydouhard August 28, 2023 09:34
tpatel
tpatel reviewed Aug 28, 2023
View reviewed changes
src/chainlit/utils.py Outdated Show resolved Hide resolved
@xsyann xsyann merged commit 305606a into main Aug 28, 2023
@willydouhard willydouhard deleted the yk/version-compare branch September 7, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpatel tpatel tpatel left review comments

@willydouhard willydouhard willydouhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsyann @tpatel @willydouhard