Run ci / cd pipeline in multicore #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois141
force-pushed
the
252-just-test-dont-work-with-multiple-cores
branch
from
5ff888b
to
19e9ee8
Compare
francois141
changed the title
francois141
force-pushed
the
252-just-test-dont-work-with-multiple-cores
branch
7 times, most recently
from
1705ab6
to
f857f2c
Compare
|
I don't think we should move all of the integration tests to multi-core. Not all of them are designed with multi-core in mind, so they might just be buggy and break down later. For our custom integration test I think single core is better, they are designed to test specific parts of Miralis, and debugging breakage on single core will be much easier. What we could do is run Linux/OpenSBI on multi-core though, but I would keep all other firmware as is. |
|
Got it! I will do the changes |
francois141
force-pushed
the
252-just-test-dont-work-with-multiple-cores
branch
from
f857f2c
to
3790b08
Compare
Now we run the ci/cd pipeline with a single core. Going multicore make the tests overall more robust to pass as we might encounters race conditions.
francois141
force-pushed
the
252-just-test-dont-work-with-multiple-cores
branch
from
3790b08
to
ab27968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.