Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetBrains | Fix Deprecated getActionUpdateThread function (AST-65497) #273

Merged
merged 4 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@
public class GlobalSettingsComponent implements SettingsComponent {
private static final Logger LOGGER = Utils.getLogger(GlobalSettingsComponent.class);

private final static GlobalSettingsState SETTINGS_STATE = GlobalSettingsState.getInstance();
private final static GlobalSettingsSensitiveState SENSITIVE_SETTINGS_STATE
= GlobalSettingsSensitiveState.getInstance();
private static GlobalSettingsState SETTINGS_STATE;
private static GlobalSettingsSensitiveState SENSITIVE_SETTINGS_STATE;

private final MessageBus messageBus = ApplicationManager.getApplication().getMessageBus();

Expand All @@ -52,6 +51,12 @@ public class GlobalSettingsComponent implements SettingsComponent {
private final JBLabel validateResult = new JBLabel();

public GlobalSettingsComponent() {
if (SETTINGS_STATE == null) {
SETTINGS_STATE = GlobalSettingsState.getInstance();
}
if (SENSITIVE_SETTINGS_STATE == null) {
SENSITIVE_SETTINGS_STATE = GlobalSettingsSensitiveState.getInstance();
}
addValidateConnectionListener();

setupFields();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import com.intellij.ide.ActivityTracker;
import com.intellij.ide.util.PropertiesComponent;
import com.intellij.notification.NotificationType;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.diagnostic.Logger;
Expand Down Expand Up @@ -62,8 +63,12 @@ public void update(@NotNull AnActionEvent e) {
e.getPresentation().setEnabled(isScanRunning);
}
catch (Exception ex) {
ex.printStackTrace();
e.getPresentation().setEnabled(false);
e.getPresentation().setEnabled(true);
}
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.BGT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.checkmarx.intellij.Bundle;
import com.checkmarx.intellij.Resource;
import com.checkmarx.intellij.tool.window.CxToolWindowPanel;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import org.jetbrains.annotations.NotNull;
Expand All @@ -28,4 +29,9 @@ public CollapseAllAction() {
public void actionPerformed(@NotNull AnActionEvent e) {
Optional.ofNullable(getCxToolWindowPanel(e)).ifPresent(CxToolWindowPanel::collapseAll);
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.checkmarx.intellij.Bundle;
import com.checkmarx.intellij.Resource;
import com.checkmarx.intellij.tool.window.CxToolWindowPanel;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import org.jetbrains.annotations.NotNull;
Expand All @@ -28,4 +29,9 @@ public ExpandAllAction() {
public void actionPerformed(@NotNull AnActionEvent e) {
Optional.ofNullable(getCxToolWindowPanel(e)).ifPresent(CxToolWindowPanel::expandAll);
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.checkmarx.intellij.Bundle;
import com.checkmarx.intellij.Resource;
import com.checkmarx.intellij.settings.global.GlobalSettingsConfigurable;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.options.ShowSettingsUtil;
Expand All @@ -27,4 +28,9 @@ public void actionPerformed(@NotNull AnActionEvent e) {
ShowSettingsUtil.getInstance()
.showSettingsDialog(e.getProject(), GlobalSettingsConfigurable.class);
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.intellij.ide.ActivityTracker;
import com.intellij.ide.util.PropertiesComponent;
import com.intellij.notification.*;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.diagnostic.Logger;
Expand Down Expand Up @@ -71,7 +72,6 @@ public static Boolean getUserHasPermissionsToScan() {
userHasPermissionsToScan = TenantSetting.isScanAllowed();
} catch (Exception ex) {
userHasPermissionsToScan = false;
LOGGER.error(ex);
}
}
return userHasPermissionsToScan;
Expand Down Expand Up @@ -289,7 +289,6 @@ public void update(@NotNull AnActionEvent e) {
e.getPresentation().setEnabled(!isScanRunning && !isPollingScan && !scanTriggered && projectAndBranchSelected);
}
catch (Exception ex) {
LOGGER.error(ex);
e.getPresentation().setEnabled(false);
}
}
Expand All @@ -311,4 +310,9 @@ public static void cancelRunningScan() {
private static String msg(Resource resource, Object... params) {
return Bundle.message(resource, params);
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.BGT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.checkmarx.intellij.tool.window.ResultState;
import com.checkmarx.intellij.tool.window.Severity;
import com.checkmarx.intellij.tool.window.actions.CxToolWindowAction;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.ToggleAction;
import com.intellij.openapi.application.ApplicationManager;
Expand Down Expand Up @@ -211,4 +212,9 @@ public interface FilterChanged {
*/
void filterChanged();
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.checkmarx.intellij.tool.window.actions.group.by;

import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.DefaultActionGroup;
import com.intellij.openapi.project.DumbAware;
Expand All @@ -12,4 +13,9 @@ public void update(@NotNull AnActionEvent e) {
super.update(e);
e.getPresentation().setEnabled(true);
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.checkmarx.intellij.tool.window.actions.CxToolWindowAction;
import com.checkmarx.intellij.tool.window.GroupBy;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.ToggleAction;
import com.intellij.openapi.util.NlsActions;
Expand Down Expand Up @@ -32,4 +33,9 @@ public void setSelected(@NotNull AnActionEvent e, boolean state) {
}

protected abstract GroupBy getGroupBy();

@Override
public ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.checkmarx.intellij.tool.window.actions.CxToolWindowAction;
import com.intellij.icons.AllIcons;
import com.intellij.ide.util.PropertiesComponent;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.DefaultActionGroup;
import com.intellij.openapi.project.DumbAware;
Expand Down Expand Up @@ -83,4 +84,10 @@ public void update(@NotNull AnActionEvent e) {
* @param scan overriding scan
*/
abstract void override(Scan scan);

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import com.checkmarx.intellij.Constants;
import com.checkmarx.intellij.Resource;
import com.checkmarx.intellij.Utils;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.application.ApplicationManager;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.checkmarx.intellij.Resource;
import com.checkmarx.intellij.tool.window.actions.CxToolWindowAction;
import com.intellij.icons.AllIcons;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import lombok.Getter;
Expand Down Expand Up @@ -45,4 +46,9 @@ public void actionPerformed(@NotNull AnActionEvent e) {
cxToolWindowPanel.resetPanel();
});
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.checkmarx.intellij.commands.Scan;
import com.checkmarx.intellij.tool.window.actions.CxToolWindowAction;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.DefaultActionGroup;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.project.DumbAware;
Expand Down Expand Up @@ -64,15 +65,23 @@ public void setEnabled(boolean enabled) {
projectSelectionGroup.setEnabled(enabled);
branchSelectionGroup.setEnabled(enabled);
scanSelectionGroup.setEnabled(enabled);
resetSelectionAction.setEnabled(enabled);
if (resetSelectionAction != null) {
resetSelectionAction.setEnabled(enabled);
}
refreshPanel(project);
}


public void reset() {
projectSelectionGroup.clear();
branchSelectionGroup.clear();
scanSelectionGroup.clear();
refreshPanel(project);
projectSelectionGroup.refresh();
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
return ActionUpdateThread.EDT;
}
}
Loading