Skip to content

Commit

Permalink
Do not use venv lock for uv venv
Browse files Browse the repository at this point in the history
Fixes a dead lock. The bazel process which is started will hold the venv
lock, even after the execution of the make target would finish.

I assume the lock is not needed if the whole venv build procedure is
under the control of bazel. Bazel cares about concurrent invocations
which pipenv did not so well.

Change-Id: Iede293b80b8f12420c6588777bbd80c99899b3f7
  • Loading branch information
LarsMichelsen committed Dec 5, 2024
1 parent fa5b8e2 commit 34b508b
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,4 @@ Pipfile.lock:

# .venv_uv is PHONY because the dependencies are resolved by bazel
.venv_uv: Pipfile.lock
@( \
flock $(LOCK_FD); \
$(REPO_PATH)/scripts/run-bazel.sh run //:create_venv \
) $(LOCK_FD)>$(LOCK_PATH)
$(REPO_PATH)/scripts/run-bazel.sh run //:create_venv

0 comments on commit 34b508b

Please sign in to comment.