Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump chia_rs to the latest version #19112

Merged
merged 1 commit into from
Jan 8, 2025
Merged

bump chia_rs to the latest version #19112

merged 1 commit into from
Jan 8, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 8, 2025 •
edited
Loading

Purpose:

The latest version addresses some bytes values that should be bytes32, which affects how they are printed to the log.

The poetry.lock file has already been updated to 0.17.0, but somehow we failed to update the pyproject.toml file.

#19059

The full change log is here: https://github.com/Chia-Network/chia_rs/releases/tag/0.17.0

Current Behavior:

Coin.name() returns bytes and is printed as escaped ascii.

New Behavior:

Coin.name() returns bytes32 and is printed as hex.

Testing Notes:

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jan 8, 2025
@arvidn arvidn marked this pull request as ready for review January 8, 2025 12:07
@arvidn arvidn requested a review from a team as a code owner January 8, 2025 12:07
@arvidn arvidn requested a review from wjblanke January 8, 2025 12:09
wjblanke
wjblanke approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jan 8, 2025
@pmaslana pmaslana merged commit 5121c5a into main Jan 8, 2025
363 of 364 checks passed
@pmaslana pmaslana deleted the bump-chia-rs-0.17.0 branch January 8, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-o-how matt-o-how matt-o-how approved these changes

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @wjblanke @matt-o-how @pmaslana