Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchup: into long_lived/datalayer_merkle_blob from main @ 115cba194f8860767c5a0b31742517577966bf8e #19169

Conversation

altendky
Copy link
Contributor

Source hash: 115cba1
Remaining commits: 0

matt-o-how and others added 3 commits January 17, 2025 09:58
…19055)

* add dependency for chia_puzzles_py

* migrate cat and dao wallets to new repo

* migrate did wallet

* more migration and deduplication

* change singleton launcher hash import in rpc

* stop importing singleton launcher from nft_puzzles in nft_wallet

* remove SINGLETON_LAUNCHER_PUZZLE import from nft_puzzles

* remove unused import

* ruff check and fix

* use graftroot dl offers from chia_puzzles_py

* get rid of more non explicit exports

* remove circular dependency

* ruff check

* migrate py files in puzzles to use chia_puzzles_py

* fix import

* fix more imports

* migrate clawback wallet and fix typo (requires version update of chia_puzzles_py)

* delete puzzles and separate nft puzzles from puzzle_utils

* use 0.19.1 version of chia_puzzles_py

* more nft puzzle detangling

* use latest chia_puzzles_py and migrate pools

* ruff fixes

* delete pool puzzles folder

* remove load_clvm from test_singleton and test_singleton_lifecycle_fast

* mypy fixes

* ruff fixes

* remove manage_clvm check precommit hook

* update version

* update chia_puzzles dependency to 0.19.4

* remove full_node puzzles

* remove test for condition codes

* change generator type to SerializedProgram

* remove remaining load_clvms that can be factored out

* delete consensus puzzles

* fix test_singleton_lifecycle_fast

* cast debug_spend_bundle coin name to bytes32

* ruff debug_spend_bundle

* update chia-puzzles and fix typo

* fix line endings

* fix typo in ROM_BOOTSTRAP_GENERATOR references

* remove bytes32 cast from debug_spend_bundle

* update chia-puzzles-py dependency to version 0.20.1 and refactor ACS_TRANSFER_PROGRAM initialization

* remove unused puzzle files

* singleton_top_layer exports hashs now which are imported from chia_puzzles

* remove .get_tree_hash() in favor of importing the hash

* remaining hash imports

* regenerate poetry.lock and pyproject.toml from main

* import singleton launcher hash from explicit export

* import SINGLETON_LAUNCHER_HASH from chia.wallet.singleton in test_pool_rpc.py

* import SINGLETON_MOD_HASH from chia.wallet.puzzles.singleton_top_layer in test_pool_puzzles_lifecycle.py

* poetry lock --no-update post-rebase

* re-regenerate lock file --no-update

* fix rebased block_tools
* dump shellcheck and actionlint versions in ci

* forward slashes
…long_lived_datalayer_merkle_blob_from_main_115cba194f8860767c5a0b31742517577966bf8e
@altendky altendky requested review from a team as code owners January 22, 2025 17:29
@altendky altendky added checkpoint_merge Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jan 22, 2025
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/chia-puzzles-py@0.20.1 None 0 105 kB chia-network

View full report↗︎

Copy link
Contributor

File Coverage Missing Lines
chia/wallet/nft_wallet/nft_puzzle_utils.py 90.6% lines 48, 53, 61, 73, 203, 216, 223-227, 237, 251
Total Missing Coverage
445 lines 13 lines 97%

@altendky altendky merged commit 9ce78d7 into long_lived/datalayer_merkle_blob Jan 22, 2025
301 of 302 checks passed
@altendky altendky deleted the catchup/long_lived_datalayer_merkle_blob_from_main_115cba194f8860767c5a0b31742517577966bf8e branch January 22, 2025 19:23
Copy link

Pull Request Test Coverage Report for Build 12913741329

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 432 of 445 (97.08%) changed or added relevant lines in 50 files are covered.
  • 26 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/nft_wallet/nft_puzzle_utils.py 125 138 90.58%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.24%
chia/farmer/farmer.py 1 73.37%
chia/wallet/util/wallet_sync_utils.py 1 86.14%
chia/daemon/server.py 1 83.46%
chia/full_node/full_node_api.py 1 84.38%
chia/full_node/full_node.py 1 86.08%
chia/daemon/client.py 2 74.16%
chia/wallet/puzzles/load_clvm.py 2 50.63%
chia/consensus/blockchain.py 2 94.14%
chia/server/node_discovery.py 3 79.49%
Totals Coverage Status
Change from base Build 12892964538: -0.02%
Covered Lines: 105463
Relevant Lines: 115123

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog checkpoint_merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants