-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more mypy #125
Conversation
Pull Request Test Coverage Report for Build 8424848351Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In chia_rs
.as_atom()
was changed to raise when .atom
was None
. If we make that same change here, it will simplify a lot of areas it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking.
catch up of #107
Broad Concerns:
AssertionError
if an object isNone
where previously aTypeError
would have been raised where we take thelen()
of the object.Draft For:
TODO:
s