Fix Fabric API 0.86.0+ #1179
Closed
Fix Fabric API 0.86.0+ #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Im fed up of marking things as duplicates lol. Theres probably more duplicates that havent been mentioned it fixes due to other issues with more mods. Hopefully with this people might stop opening more issues. Artifact with just this fix for users: https://github.com/Chocohead/OptiFabric/suites/15107712000/artifacts/863241949 //DO NOT USE THE ARTIFACT, THIS IS FOR TESTING ONLY!!! updated with regression fix YOU MUST DELETE THE .OPTIFINE FOLDER TO USE THIS ARTIFACT EDIT 3: think, people, think. My god. how to use:
|
|
Doesn't work for me on 1.20.1 with fabric api 0.86 or 0.87. |
Did you delete the
Assuming it's the first time optifine is processed (which realistically will happen to very few users) it should work fine. Otherwise you have to delete the cache and launch again. I don't know how to fix this, maybe Chocohead is able to help. |
Ah my bad I must have missed that, thanks. |
|
Indeed removing Tested with:
|
This was referenced Aug 15, 2023
This was referenced Aug 15, 2023
|
The .optifine folder just comes back after launching minecraft |
|
It's a cache folder, it's supposed to do that. The reason you may need to delete it (once) is to clear bad cache and allow the mod to regenerate it correctly. |
|
I tried this with Optifine 1.20.1 , Fabric api 86.1 and Optifabric 1.13.25 Deleted the optifine folder, downgraded Fabric Api and im still recieving error code exit 1. Am I missing something? EDIT: I had to delete the whole .minecraft folder not just the .optifine folder for the fix to be applicable (try that if nothings working) |
|
Hi there, trying to use optifine/optifabric with Fabric 0.86/0.87, I'm a bit confused as to what I'm supposed to do to get them to work. I am running on a macbook btw if someone can help me get them to work? thanks |
So what the poster did was delete the optifine folder with Fabric Api .85 (.86 didn't work for me) and the launch and it should go through. For me i had to delete the .minecraft folder completely and do it. |
Wrong. Use the updated artifact I posted, delete the .optifine folder and restart Minecraft with new fabric API. |
|
My bad G |
All good, just saves him trying it and it not working haha. |
|
Optifine and optifabric both work for me on fabric api 0.85, but if I do those things will it work on 0.86 or 0.87? |
By the sounds of it you’re better off waiting for an official update. Yes, it will work if you do those, but if currently you’re fine just don’t change it. |
|
Okay thanks, is there any word on an official update yet? |
Hi mate, |
|
Please don’t use the PR for discussion related to it, this is really only for comments regarding merging / discussion on commits. |
Are you able to help me fix this as you seem pretty knowledgeable on this issue. |
Last time I’ll reference this, and hopefully Choco or XMA can clean up. Read my former post with the artifact, there’s simple instructions now. |
Tried this, it keeps crashing. Exit code:1 |
XXMA16
added a commit
to XXMA16/OptiFabric
that referenced
this pull request
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #1201
Quick note:
If the Optifine cache in the
.optifinefolder already exists, the new mappings will not take effect. The easiest way of fixing this is manually deleting the.optifinefolder. Users will likely expect the game to work properly if they update to a version with the changelog Fixed Fabric API 0.86.0+ without having to do any additional stuff, making this a slight issue.This still applies after the second commit!
Testing
Fabric API introduced the Model Loading API in version 0.86.0 and since the new mixin config takes effect only when that module is present it should not break anything that wasn't broken already. As such I did minimal testing edit: bad idea, everything that can go wrong will go wrong, the
only configurationconfigurations that I knowisare working properly being:by "working" I mean the following:
-Dmixin.debug.export=trueclasses confirms this)Regarding the fix itself:
I was not able to get the Intercepting Mixin Plugin working without also messing with stuff in
postApply()(as evidenced by my saltiness here) due to Mixin complaining aboutInvalidImplicitDiscriminatorException(even though I think I followed the same principle applied inOriginMixinPlugin). On top of that, Mixin would also throw the same exception if I tried to put the fake calls (with or without someACONST_NULLs andPOPs) before the other instructions of the vanillabakemethod (thus I resorted to using twoInsnLists). The other stuff is pretty straight-forward, even though it took me pretty long to understand that@Shimming methods does not also solve the issue of Mixin not finding the target and that has to be dealt with manually (because reading is hard). On a side note, half the problems I encountered when writing the fix consisted of me writing wrong descriptors and the other half of my bad understanding of Optifabric's codebase (if we exclude that damned@ModifyVariablewhich I still don't understand why it's so picky).Fixed issues
fixes #1123 fixes #1124 fixes #1127 fixes #1134 fixes #1136 fixes #1139 fixes #1151 fixes #1153 fixes #1156 fixes #1157 fixes #1161 fixes #1166 fixes #1169 fixes #1172 fixes #1177 fixes #1181 fixes #1182 fixes #1183 fixes #1184 fixes #1185 fixes #1186 fixes #1187 fixes #1188 fixes #1189
Please merge or at least consider merging #94 because the repo's issues page is full of duplicates, vague issues, the occasional why doesn't this work with sodium, etc.