Skip to content

Commit

Permalink
Roll browser-protocol
Browse files Browse the repository at this point in the history
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8743287383250743985

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: I2507f9f8643f8ef5044180f9e854e7857edd7f4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5679266
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
  • Loading branch information
devtools-ci-autoroll-builder authored and Devtools-frontend LUCI CQ committed Jul 5, 2024
1 parent 924592b commit 30c620c
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 8 deletions.
12 changes: 11 additions & 1 deletion front_end/generated/SupportedCSSProperties.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ export const generatedProperties = [
],
"name": "-alternative-animation-with-timeline"
},
{
"longhands": [
"position-try-order",
"position-try-fallbacks"
],
"name": "-alternative-position-try"
},
{
"inherited": true,
"name": "-webkit-border-horizontal-spacing"
Expand Down Expand Up @@ -2770,6 +2777,9 @@ export const generatedProperties = [
"flip-inline",
"flip-start"
],
"name": "position-try-fallbacks"
},
{
"name": "position-try-options"
},
{
Expand Down Expand Up @@ -5227,7 +5237,7 @@ export const generatedPropertyValues = {
"auto"
]
},
"position-try-options": {
"position-try-fallbacks": {
"values": [
"none",
"flip-block",
Expand Down
2 changes: 1 addition & 1 deletion front_end/generated/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3159,7 +3159,7 @@ export namespace CSS {
*/
cssPositionFallbackRules?: CSSPositionFallbackRule[];
/**
* A list of CSS @position-try rules matching this node, based on the position-try-options property.
* A list of CSS @position-try rules matching this node, based on the position-try-fallbacks property.
*/
cssPositionTryRules?: CSSPositionTryRule[];
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4632,7 +4632,7 @@
},
{
"name": "cssPositionTryRules",
"description": "A list of CSS @position-try rules matching this node, based on the position-try-options property.",
"description": "A list of CSS @position-try rules matching this node, based on the position-try-fallbacks property.",
"optional": true,
"type": "array",
"items": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2207,7 +2207,7 @@ experimental domain CSS
optional array of CSSKeyframesRule cssKeyframesRules
# A list of CSS position fallbacks matching this node.
deprecated optional array of CSSPositionFallbackRule cssPositionFallbackRules
# A list of CSS @position-try rules matching this node, based on the position-try-options property.
# A list of CSS @position-try rules matching this node, based on the position-try-fallbacks property.
optional array of CSSPositionTryRule cssPositionTryRules
# A list of CSS at-property rules matching this node.
optional array of CSSPropertyRule cssPropertyRules
Expand Down
23 changes: 19 additions & 4 deletions third_party/blink/renderer/core/css/css_properties.json5
Original file line number Diff line number Diff line change
Expand Up @@ -4550,19 +4550,25 @@
invalidate: ["layout", "paint"],
},
{
name: "position-try-options",
name: "position-try-fallbacks",
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
style_builder_custom_functions: ["value"],
field_group: "*",
field_template: "external",
keywords: ["none", "flip-block", "flip-inline", "flip-start"],
typedom_types: ["Keyword"],
include_paths: ["third_party/blink/renderer/core/style/position_try_options.h"],
include_paths: ["third_party/blink/renderer/core/style/position_try_fallbacks.h"],
wrapper_pointer_name: "Member",
type_name: "PositionTryOptions",
type_name: "PositionTryFallbacks",
default_value: "nullptr",
invalidate: ["layout", "paint"],
runtime_flag: "CSSAnchorPositioning",
runtime_flag: "CSSPositionTryFallbacks",
},
{
name: "position-try-options",
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
surrogate_for: "position-try-fallbacks",
runtime_flag: "CSSPositionTryOptions",
},
{
name: "position-try-order",
Expand Down Expand Up @@ -8154,6 +8160,15 @@
property_methods: ["ParseShorthand", "CSSValueFromComputedStyleInternal"],
runtime_flag: "CSSPositionTryOrder",
},
{
// Variant of the "position-try" shorthand which has the new
// position-try-fallbacks instead of position-try-options.
name: "-alternative-position-try",
alternative_of: "position-try",
longhands: ["position-try-order", "position-try-fallbacks"],
property_methods: ["ParseShorthand", "CSSValueFromComputedStyleInternal"],
runtime_flag: "CSSPositionTryFallbacks",
},
{
name: "scroll-margin",
longhands: ["scroll-margin-top", "scroll-margin-right", "scroll-margin-bottom", "scroll-margin-left"],
Expand Down

0 comments on commit 30c620c

Please sign in to comment.