[Freestyler] Don't show "Fix this issue" button when the last action …

…was to "fix this issue"

Fixed: 338931042
Change-Id: Id3b714174d0c20c1a848d9e09dae6d96a08e53fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5677363
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>

front_end/panels/freestyler/FreestylerPanel.ts

@@ -126,6 +126,7 @@ export class FreestylerPanel extends UI.Panel.Panel {
  inspectElementToggled: this.#toggleSearchElementAction.toggled(),
  selectedNode: this.#selectedNode,
  isLoading: false,
+ lastActionIsFixThisIssue: false,
  onTextSubmit: this.#handleTextSubmit.bind(this),
  onInspectElementClick: this.#handleSelectElementClick.bind(this),
  onRateClick: this.#handleRateClick.bind(this),
@@ -247,6 +248,7 @@ export class FreestylerPanel extends UI.Panel.Panel {
  entity: ChatMessageEntity.USER,
  text,
  });
+ this.#viewProps.lastActionIsFixThisIssue = text === FIX_THIS_ISSUE_PROMPT;
  this.#viewProps.isLoading = true;
  let systemMessage: ModelChatMessage = {
  entity: ChatMessageEntity.MODEL,

front_end/panels/freestyler/components/FreestylerChatUi.ts

@@ -167,23 +167,24 @@ export const enum Rating {
  NEGATIVE = 'negative',
 }
 
-export type Props = {
- onTextSubmit: (text: string) => void,
- onInspectElementClick: () => void,
- onRateClick: (rpcId: number, rate: Rating) => void,
- onAcceptConsentClick: () => void,
- onCancelClick: () => void,
- onFixThisIssueClick: () => void,
- inspectElementToggled: boolean,
- state: State,
- aidaAvailability: Host.AidaClient.AidaAvailability,
- messages: ChatMessage[],
- selectedNode: SDK.DOMModel.DOMNode|null,
- isLoading: boolean,
+export interface Props {
+ onTextSubmit: (text: string) => void;
+ onInspectElementClick: () => void;
+ onRateClick: (rpcId: number, rate: Rating) => void;
+ onAcceptConsentClick: () => void;
+ onCancelClick: () => void;
+ onFixThisIssueClick: () => void;
+ inspectElementToggled: boolean;
+ state: State;
+ aidaAvailability: Host.AidaClient.AidaAvailability;
+ messages: ChatMessage[];
+ selectedNode: SDK.DOMModel.DOMNode|null;
+ isLoading: boolean;
  // If there is a `confirmSideEffectDialog`, we show the
  // confirmation dialog for executing that specific code.
- confirmSideEffectDialog?: ConfirmSideEffectDialog,
-};
+ confirmSideEffectDialog?: ConfirmSideEffectDialog;
+ lastActionIsFixThisIssue: boolean;
+}
 
 // The model returns multiline code blocks in an erroneous way with the language being in new line.
 // This renderer takes that into account and correctly updates the parsed multiline token with the language
@@ -381,7 +382,8 @@ export class FreestylerChatUi extends HTMLElement {
 
  // TODO: We should only show "Fix this issue" button when the answer suggests fix or fixes.
  // We shouldn't show this when the answer is complete like a confirmation without any suggestion.
- const shouldShowFixThisIssueButton = isLast && message.steps.at(-1)?.step === Step.ANSWER;
+ const shouldShowFixThisIssueButton =
+ isLast && message.steps.at(-1)?.step === Step.ANSWER && !this.#props.lastActionIsFixThisIssue;
  const shouldShowRating = (!this.#props.confirmSideEffectDialog && isLast) || !isLast;
  const shouldShowLoading = !this.#props.confirmSideEffectDialog && this.#props.isLoading && isLast;
  // clang-format off

front_end/ui/components/docs/freestyler/basic.ts

@@ -56,6 +56,7 @@ const component = new Freestyler.FreestylerChatUi({
  messages,
  selectedNode: {} as unknown as SDK.DOMModel.DOMNode,
  isLoading: false,
+ lastActionIsFixThisIssue: false,
 });
 
 document.getElementById('container')?.appendChild(component);

front_end/ui/components/docs/freestyler/empty_state.ts

@@ -26,6 +26,7 @@ const component = new Freestyler.FreestylerChatUi({
  messages: [],
  selectedNode: {} as unknown as SDK.DOMModel.DOMNode,
  isLoading: false,
+ lastActionIsFixThisIssue: false,
 });
 
 document.getElementById('container')?.appendChild(component);