Avoid stack overflow when disposing batched sink #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Apr 2, 2024
wparad
reviewed
Apr 2, 2024
wparad
requested changes
Apr 2, 2024
|
Done - thanks for the review. |
wparad
approved these changes
Apr 2, 2024
|
Thank you for helping to fix this. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
The normal chain of disposal when using
PeriodicBatchingSinkisLogger→PeriodicBatchingSink→(IDisposable)IBatchedLogEventSink. The sink added to the logging pipeline is aPeriodicBatchingSinkinstance, and the batched sink isn't normally exposed.Because
CloudWatchLogSinkis a public type in this project, in #111 I intended to keep the API as compatible as possible and made the sink and batched sink the same type -CloudWatchLogSink. This led to the aforementioned bug.This PR switches to the new scheme, but keeps
CloudWatchLogSinkas a backwards-compatible adapter.