Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for netstandard2.0 #137

Merged
merged 1 commit into from
May 20, 2024

Conversation

a-jackson
Copy link
Contributor

Requires reverting the code to C# 7.3 and making the DisposeAsync conditional on the net6.0 build

@wparad
Copy link
Collaborator

wparad commented May 10, 2024

I'm sorry this is too many changes, we can't support the validation that would be required here. As I mentioned in the issue, only if the changes were minimal would we be able to effectively support it. But like this, I'm afraid the burden is too high. In this case, I might suggest forking the repo to make those changes.

Copy link
Collaborator

@wparad wparad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further review, we've agreed internally that we can potentially accept this change with some minor suggested changes. Thank you for providing this!

Requires reverting the code to C# 7.3 and making the DisposeAsync conditional on the net6.0 build
@wparad wparad merged commit 4d0a7a8 into Cimpress-MCP:master May 20, 2024
1 check passed
@wparad
Copy link
Collaborator

wparad commented May 20, 2024

I've approved this and I'm merging it in. Thank you.

@a-jackson a-jackson deleted the netstandard20-support branch May 20, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants