Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recipes #35

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Feature/recipes #35

wants to merge 4 commits into from

Conversation

StudioAzur
Copy link
Collaborator

No description provided.

Copy link
Owner

@CindyGraffin CindyGraffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques trucs à revoir mais t'as compris comment créé le back, bien joué ! 👍

models/RecipesModel.ts Outdated Show resolved Hide resolved
dtos/recipes.dto.ts Outdated Show resolved Hide resolved
service/recipeService.ts Show resolved Hide resolved
Copy link
Owner

@CindyGraffin CindyGraffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste deux petits détails à résoudre mais tu peux merge si tu veux :)

times: { type: Number, required: true },
difficulty: { type: String, required: true },
ingredients: {
quantity: { type: Number },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu as juste oublié de mettre en required la qauntité des ingrédients. si cela est facultatif ignore mon commentaire

const recipeController = new RecipeController();
const recipeRouter = express.Router();

recipeRouter.post('/createrecipe', recipeController.createRecipe)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas besoin de la route 'createrecipe', juste '/' devrait suffire étant donné que le terme 'post' parle de lui -même

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants