Skip to content

Commit

Permalink
(HDS-2137) add missing icons to icons list, fix broken document-group…
Browse files Browse the repository at this point in the history
… icon, add to changelog, rename & partially rewrite icon library build workflow, fix wrong icon kit version number
  • Loading branch information
mrTuomoK committed Feb 23, 2024
1 parent 7cbae42 commit 406787b
Show file tree
Hide file tree
Showing 6 changed files with 53 additions and 26 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# Build icon library, create zip file for release and create PR
name: icon library
# Build icon library, create zip file for release and commit to current branch
name: update icon library

on:
workflow_dispatch:
push:
branches:
- release-*

jobs:
build-icon-library:
Expand All @@ -17,6 +20,24 @@ jobs:
node-version: '20.3.1'
registry-url: 'https://registry.npmjs.org'

# Don't do anything if we're on development, main or master branches
- name: Check branch
run: |
if [[ $GITHUB_REF == refs/heads/development || $GITHUB_REF == refs/heads/master || $GITHUB_REF == refs/heads/main ]]; then
echo "Development, master pr main branch, skipping icon library build"
exit 1
fi
# Don't do anything if we're on release-x.x.x AND the icon-kit has the same version number (already built for the release)
- name: Check if icon library has already been built for this release
run: |
PKG_VER=`node -pe "require('./packages/react/package.json').version"`
ICON_KIT_VER=`sed -n -E 's/.*version[[:space:]]+([0-9]+([.][0-9]+)*).*/\1/p' ./release/icon-kit-template-CHANGELOG.txt`
if [[ ${PKG_VER} == ${ICON_KIT_VER} ]]; then
echo "Icon library has already been built for this release, skipping"
exit 1
fi
- name: Run Glypfig
run: |
npx glypfig \
Expand Down Expand Up @@ -83,9 +104,4 @@ jobs:
git config --global user.name "Github Actions"
git add .
git commit -m 'Updated icon library'
git push
- name: create pull request
run: gh pr create -B development --title 'Icon library build' --body 'Created by Github action icon library'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
git push
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.X.X] - Month, XX, 202X

### React
Expand Down Expand Up @@ -41,6 +46,7 @@ Changes that are not related to specific components
#### Fixed

- [Component] What bugs/typos are fixed?
- [Icons] document-group icon wrong colors

### Documentation

Expand All @@ -51,6 +57,7 @@ Changes that are not related to specific components
#### Added

- [Component] What is added?
- [Icons] added missing icons to site icons list

#### Changed

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/icons/document-group.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 7 additions & 9 deletions packages/core/src/svg/document-group.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion release/icon-kit-template-CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Helsinki Design System, Icon kit, version 3.4.0
# Helsinki Design System, Icon kit, version 3.5.0

## CHANGELOG

Expand Down
Loading

0 comments on commit 406787b

Please sign in to comment.