HDS-1724-hero-arrow #1211
Merged
HDS-1724-hero-arrow #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrTuomoK
force-pushed
the
HDS-1724-hero-arrow
branch
from
bfbadcb
to
fbd0396
Compare
NikoHelle
approved these changes
Jan 17, 2024
| color: var(--arrow-icon-color); | ||
|
|
||
| /* the following is magic to calculate a proper margins (icon has empty space in it that is taken into account) */ | ||
| margin-left: calc(var(--padding-horizontal) - (var(--arrow-icon-size) / 4)); |
There was a problem hiding this comment.
The icon svg has soooooo much empty spacing! 😲
Could the icon be set to the exact size by wrapping it to an element which could delete extra space with negative margins?
There was a problem hiding this comment.
Maybe 🤷 It's just that the icons aren't spaced similarly to each other so it might be a hell of a job to do 😆 this 25% (or / 4) is just what works with the arrow down :D
NikoHelle
reviewed
Jan 17, 2024
NikoHelle
requested changes
Jan 17, 2024
NikoHelle
approved these changes
Jan 19, 2024
SillanmakiA
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the possibility to show an arrow icon in the bottom left corner of Hero. Also customisable by setting
--arrow-icon-colorin the Hero theme.Can be tested here (this is not the newest version, but the arrow is working exactly the same, the dummy content has been changed after this)
Related Issue
HDS-1724
How Has This Been Tested?
Screenshots (if appropriate):
Add to changelog