HDS-1514: dependency warning fixes #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikoHelle
force-pushed
the
hds-1514-depencency-warning-fixes
branch
2 times, most recently
from
d574cdf
to
076aac4
Compare
mrTuomoK
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
All ok, good work again :) Good to merge after the changelog-conflicts are fixed (and now the test conflict) 👍 ping @NikoHelle
laurakarhu
approved these changes
Feb 21, 2024
Gatsby uses latest (1.4.5-lts.1) but for some vulnerability reason it has been forced to be 1.4.4. Could not find open vulnerability for 1.4.4. or 1.4.5 so changed to newer
Splitted the resolutions to two versions instead forcing all to v2.
Also had to update plugins and prettier. Also removed some plugins/rules that have been merged into prettier/eslint-config-prettier: prettier/@typescript-eslint prettier/react Changed some rules which caused hundreds of errors in the /src.
Autofixed what could, and the manually. Fix warnings for missing labels The warning was: "A control must be associated with a text label"
Stepper had invalid props for file input and a copy-paste error.
tsconfig had extra comma Add build:code to scripts No need to build site everytime core+React is needed Removed ununsed code Lines 190 - 201 was deleted. Other changes are due autoformat.
Yarn start did not work anymore and changing eslintrc.json did not work Error: facebook/create-react-app#11864 Fixed by updating some eslint related packages by removing them from yarn.lock and running yarn. Added react as plugin to eslintrc.
postcss and @testing-library/dom added to actual (dev)/dependencies. PostCss is a devDep and peerDep Used postCss version jumped from 7 to 8. Reason is in migration guide https://evilmartians.com/chronicles/postcss-8-plugin-migration
There was a warning about 2 mocks with same name. Merged and moved to utils.
site needed some babel deps.
NikoHelle
force-pushed
the
hds-1514-depencency-warning-fixes
branch
from
076aac4
to
8cb1190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users of hds-react can see "unmet peer dependency" warnings. Some listed warnings were outdated. Other projects could still see issue with
react-spring. That was easily fixed withreact-spring/webFixed also all eslint warnings, which was surprisingly huge effort.
Fixed also old/new ts errors and other warnings raised by
yarnoryarn buildLeft Gatsby and Storybook related warnings. Those require major update HDS-1438.
Related Issue
Closes #1514
How Has This Been Tested?
Locally.
Add to changelog