(HDS-2107) remove normalize, fix styles in new builds #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrTuomoK
force-pushed
the
HDS-2107-fix-hds-core-importing
branch
2 times, most recently
from
5ddf060
to
3b639a7
Compare
mrTuomoK
changed the title
mrTuomoK
force-pushed
the
HDS-2107-fix-hds-core-importing
branch
from
5d3845b
to
fb69dd0
Compare
NikoHelle
reviewed
Feb 5, 2024
… -> base.module.css, add hds-core styles import to storybook, add some normalize styles to Header.module.scss, fix card styles import, update changelog, fix login test with window redirection tracking
mrTuomoK
force-pushed
the
HDS-2107-fix-hds-core-importing
branch
from
32f41bd
to
22811b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the way how hds-core was imported in hds-react -component (Highlight) which broke some build-systems. The correct way is importing the react base.module.css from styles folder (which just imports the hds-core/lib/base.css). For some reason importing the hds-core base.css straight breaks on new build-systems stating it's not ok to bring global css styles. Storybook doesn't nicely cope with the change and needed to add the base.module.css as import in the inde.css currently.
Related Issue
HDS-2107
How Has This Been Tested?
Screenshots (if appropriate):
Add to changelog