Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog-templater #1222

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Changelog-templater #1222

merged 1 commit into from
Feb 9, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Feb 6, 2024

Description

This takes the CHANGELOG.md and prepends the ./changelog_templater/CHANGELOG.template.md to it. Makes life easier when after release the empty template should be prepended to the existing Changelog.

Motivation and Context

To make our lives easier.

@mrTuomoK mrTuomoK requested a review from a team February 6, 2024 11:19
@mrTuomoK mrTuomoK force-pushed the changelogger branch 2 times, most recently from b71711a to 3947c6d Compare February 6, 2024 12:26
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File/folder names do not follow current conventions. "_" is not used in those. Current is a mix of camel and kebab cases.

There is no "scripts"-folder in root, but maybe we should create one and add this there instead of root, like:

./scripts
./scripts/changelog/

package.json Outdated Show resolved Hide resolved
changelog_templater/CHANGELOG.template.md Outdated Show resolved Hide resolved
changelog_templater/changelog_templater.js Outdated Show resolved Hide resolved
@mrTuomoK
Copy link
Contributor Author

mrTuomoK commented Feb 7, 2024

Now everything should be fixed @NikoHelle. I also put the empty space at the and of the template so no need to add line-breaks anymore in code-side.

CHANGELOG.md Outdated Show resolved Hide resolved
@mrTuomoK mrTuomoK merged commit 52a3bd8 into development Feb 9, 2024
6 checks passed
@mrTuomoK mrTuomoK deleted the changelogger branch February 9, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants