Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HDS-2108) remove useless @layer style #1225

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Feb 8, 2024

Description

This rule broke Jest/jsdom tests and after looking at our implementation, the whole @layer is useless here

Related Issue

HDS-2108

How Has This Been Tested?

  • manually with storybook
  • local visual-tests

Add to changelog

  • Added needed line to changelog

@mrTuomoK mrTuomoK requested a review from a team February 8, 2024 12:59
@laurakarhu laurakarhu requested a review from a team February 21, 2024 13:31
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mrTuomoK mrTuomoK force-pushed the HDS-2108-replace-css-layer-rule branch from 2e0307a to 3018a5f Compare February 23, 2024 09:29
@mrTuomoK mrTuomoK merged commit d356f3e into development Feb 23, 2024
6 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2108-replace-css-layer-rule branch February 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants