(release-4.0.0) hds-2522: clean up announcements #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the element need to stay. Not sure when exactly, but did not change it in this PR.
The element must be visually hidden. It is outside of added style element's scope, so have to hide via style attribute.
|
Preview found from hds-demo docs/preview_1427 Demos |
Test Results 1 files 64 suites 11m 49s ⏱️ Results for commit c788dd9. |
mrTuomoK
reviewed
Nov 19, 2024
mrTuomoK
requested changes
Nov 19, 2024
mrTuomoK
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code cleaning for the announcements. Also the banner's aria-live element was always removed, never announced. Made it visible to screen readers only.
Related Issue
Closes HDS-2522
Motivation and Context
How Has This Been Tested?
Added e2e tests
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog