(release-4.0.0) HDS-2532 fix events #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview found from hds-demo docs/preview_1435 Demos |
Test Results 1 files 64 suites 11m 42s ⏱️ Results for commit 4dde606. ♻️ This comment has been updated with latest results. |
The double rendering in CRA showed that listeners are not added after mount + unmount + mount again
NikoHelle
force-pushed
the
hds-2532-fix-events
branch
from
cb214d4
to
4dde606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
window.addEventListeners were not called after mount+unmount+mount again.
Related Issue
Closes HDS-2532
Motivation and Context
How Has This Been Tested?
No new tests needed.
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog