Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert login props #1438

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Revert login props #1438

merged 1 commit into from
Nov 21, 2024

Conversation

NikoHelle
Copy link
Contributor

Description

Local login settings were accidentally committed at some point.

Local settings were committed at some point.
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Test Results

  1 files   64 suites   11m 48s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 6822e4b.

Copy link

Preview found from hds-demo docs/preview_1438

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@NikoHelle NikoHelle merged commit 91e22ac into release-4.0.0 Nov 21, 2024
8 checks passed
@NikoHelle NikoHelle deleted the revert-login-props branch November 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants