-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.0.0 #1439
Merged
Merged
Release 4.0.0 #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outside click is not detected if any component in the DOM tree calls e.preventDefault() until it reaches the window. Capturing prevents this kind of "cancel"
…initTests renderWithHelpers returns better helpers. Default id of the select changed where initTests() was used so snapshots changed too.
This is to suppress "not found" errors with some *.module.scss
Best to keep selectors with the HTML code. Selectors are needed when resolving where user interactions with mouse/keyboard happened. Also used to shift focus when navigating with keyboard.
Used to find out which kind of element had an event and where to find an element and pick siblings etc for navigation.
Handles: - when menu is opened focus is moved to first element - when list loses focus, it is closed - when a tag is removed focus is moved to first tag / button - button is focused after many changes Tracks active-descendant for screen readers Calls also blur / focus callbacks
Commented out recordVideo-prop or VSCode plugin records videos
There will be many more utils, so this is better namings
If options are random, visual tests fail. Added also ids to find components in PW tests
…ract-from-CHANGELOG.template remove Sketch & Abstract from CHANGELOG.template since obsolete
(release-4.0.0) HDS-2532 fix events
…51024 (Release-4.0.0) HDS-2069: Select docs
… site settings template
Local settings were committed at some point.
Revert login props
NikoHelle
approved these changes
Nov 21, 2024
Test Results 1 files 64 suites 11m 43s ⏱️ Results for commit 333e5a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.0.0] - November, 21, 2024
React
Breaking
Added
Changed
Changes that are not related to specific components
Fixed
Core
Breaking
Added
Fixed
Design tokens
Breaking
black-60
from#666666
to#595959
due to contrast issues and the accessibility and readability improvement.Documentation
Breaking
Added
Changed
Changes that are not related to specific components
Fixed
Figma
Added
Fixed
Changed
Deprecated
Hds-js
Breaking
Added