Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile #18

Closed
wants to merge 4 commits into from
Closed

Update dockerfile #18

wants to merge 4 commits into from

Conversation

laurigates
Copy link
Contributor

No description provided.

- Removed unneeded variables
- Added labels to dockerfile to link image to mittaridatapumppu
  repository
Copied from mittaridatapumppu-deviceregistry
- Removed workaround config related to a setuptools issue
Work-in-progress, still need to run migrations in deviceregistry
service.
@@ -2,9 +2,20 @@

FROM python:3.11-alpine

LABEL org.opencontainers.image.source=https://github.com/city-of-helsinki/mittaridatapumppu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct anymore

Copy link
Member

@jussiarpalahti jussiarpalahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jussiarpalahti
Copy link
Member

Is docker compose here required, since https://github.com/City-of-Helsinki/mittaridatapumppu/blob/main/docker-compose.yml has the main one?

@laurigates laurigates closed this Jan 12, 2024
@laurigates laurigates deleted the update_dockerfile branch January 12, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants