Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change env names to make them consistent #20

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Change env names to make them consistent #20

merged 1 commit into from
Oct 18, 2023

Conversation

aapris
Copy link
Contributor

@aapris aapris commented Oct 18, 2023

Check Platta and device registry too

laurigates
laurigates approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@laurigates laurigates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll update the envs on Platta.

@aapris
Copy link
Contributor Author

aapris commented Oct 18, 2023

Test fails due from hostname, it should probably be deviceregistry:8000 ?
ERROR in app: Failed to get endpoints from device registry [http://127.0.0.1:8000/api/v1/hosts/localhost/]
Merging this anyway, it can be fixed later.

@aapris aapris merged commit 11e23fe into main Oct 18, 2023
0 of 2 checks passed
@aapris aapris deleted the enhancement/change_env_name branch October 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurigates laurigates laurigates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aapris @laurigates