Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a full-fledged plot search form section editor #443

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

EmiliaMakelaVincit
Copy link
Contributor

The editor allows the user to specify all data necessary for setting up a customisable, but structurally coherent form for any specific plot search. This includes automatic identifier specification as well as protection of specific operationally important fields and sections containing said fields.

The editor allows the user to specify all data necessary for
setting up a customisable, but structurally coherent form for
any specific plot search. This includes automatic identifier
specification as well as protection of specific operationally
important fields and sections containing said fields.
Copy link
Contributor

@PasiVuohijoki PasiVuohijoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be somekind of option to create totally new application form?

image

There could be option "Luo uusi lomake" and there would be only the needed fields for UI to work.

Copy link
Contributor

@PasiVuohijoki PasiVuohijoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise and functionwise nothing to complain. I guess this can be merged and let's focus on other areas and decide the "add new form" -option later?

@EmiliaMakelaVincit
Copy link
Contributor Author

Yeah, I think that hasn't been in the scope for now. Copying an existing form from another search was discussed at some point, though, but that was also left for some other day.

@EmiliaMakelaVincit EmiliaMakelaVincit merged commit 35e15e0 into develop Oct 12, 2023
3 checks passed
@EmiliaMakelaVincit EmiliaMakelaVincit deleted the plot-search-field-editor branch October 12, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants