toggleable usergroup list #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried looking online for free person icons? I found for example this: https://www.svgrepo.com/svg/506667/person |
No, because I am also wondering whether info icon is a better idea than a person icon, given that the only thing it does is give some info. It is not a regular user account dropdown menu, so I am a bit doubtful whether info or person icon is better. |
|
Should we use HDS icons in case we migrate to use HDS at some stage? |
robertrytovuori
approved these changes
May 28, 2024
|
|
NC-jsAhonen
force-pushed
the
MVJ-253-usergroup-list
branch
from
60178e7
to
cd3dd51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new usergroup list looks as follows. It is toggled using the info icon. I could not find a person icon and the icons are created in the mvj-ui as manually inserted vector values, so it would take extra work to make it into a person icon. Is info icon good enough in your opinion?