Mvj 249 flow to typescript conversion #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertrytovuori How about we book time tomorrow to go through this together and browse to see if there's something of interest? |
henrinie-nc
reviewed
May 30, 2024
package.json
Outdated
| @@ -32,6 +32,7 @@ | |||
| "copy-to-clipboard": "^3.2.0", | |||
| "date-fns": "^2.0.0-beta.4", | |||
| "dotenv": "^8.0.0", | |||
| "file-loader": "^6.2.0", | |||
There was a problem hiding this comment.
It sounds a bit like file-loader, ts-loader, and utility-types should be devDependencies
henrinie-nc
approved these changes
May 30, 2024
There was a problem hiding this comment.
Big chunk of changes to review. I looked a bit here and there, nothing significant popped up.
One thing I noted was addition of some dependencies, which seemed like development dependencies, please check those and move to devDependencies if they belong there. Approving ahead of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge PR. Not sure what is the best approach to reviewing it since pretty much every .js and .jsx file has been transformed to .ts and .tsx. Also had to make some changes in webpack and other places to make the typescript work. I have ran the tests, compiled and ran the dev server.