MVJ-245_paikkatietovipunen-urls-broken-fix #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrinie-nc
reviewed
Jun 5, 2024
src/util/constants.ts
Outdated
| * @readonly | ||
| * @const {string} | ||
| */ | ||
| export const PAIKKATIETOVIPUNEN_URL = 'http://paikkatietovipunen.hel.fi:10058'; | ||
| export const PTP_URL = 'https://ptp.hel.fi'; |
There was a problem hiding this comment.
Here it would be really nice if we could figure out what PTP stands for and write it out in the variable to describe what this is
There was a problem hiding this comment.
Renamed PTP_URL to PAIKKATIETOPALVELU_URL
henrinie-nc
reviewed
Jun 5, 2024
src/util/helpers.tsx
Outdated
| * @returns {string} | ||
| */ | ||
| export const createPaikkatietovipunenUrl = (url: string): string => `${PAIKKATIETOVIPUNEN_URL}/${url}`; | ||
| export const createPTPPlanReportUrl = (reportId: string): string => `${PTP_URL}/DataForms/planreport/?id=${reportId}`; |
There was a problem hiding this comment.
Really like this approach, nice!
henrinie-nc
approved these changes
Jun 5, 2024
|
@robertrytovuori This can be merged I suppose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createPaikkatietovipunenUrl to createPTPPlanReportUrl and createPTPPlotDivisionUrl