Generate reservation series holidays #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vergama
reviewed
Sep 11, 2024
vergama
reviewed
Sep 11, 2024
ranta
force-pushed
the
generate-reservation-series-holidays
branch
2 times, most recently
from
49ea793
to
95e22b7
Compare
applications/tasks.py
Outdated
| organisation_address: Address | None = getattr(organisation, "address", None) | ||
|
|
||
| reservation_details["description"] = ( | ||
| translate_for_user(_("Core business"), application.user) + f": {organisation.core_business}" |
There was a problem hiding this comment.
This occurred to me just now: This was an issue during a previous seasonal booking round, since it can go over the reservation description char limit. I think we figured that the "Core business: " prefix should just be removed, and the description truncated to match the limit. MIght as well make the change here.
matti-lamppu
approved these changes
Sep 16, 2024
vergama
approved these changes
Sep 16, 2024
ranta
force-pushed
the
generate-reservation-series-holidays
branch
from
95e22b7
to
bea937b
Compare
- No functional changes, except better error handling in edge cases
matti-lamppu
force-pushed
the
generate-reservation-series-holidays
branch
from
bea937b
to
ec0cf05
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
override=Trueandstate=closedin HAUKI API🧪 Test plan
🚧 Dependencies
🎫 Tickets