Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Migrate resource models to the new app #1344

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[2.4] Migrate resource models to the new app #1344

merged 1 commit into from
Oct 1, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Sep 19, 2024 •
edited
Loading

🛠️ Changelog

  • See title.
  • Old migrations will remain in place until everything is moved to not break the django migration system.
  • Should follow this guide (the short way).

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added the refactor Refactors something label Sep 19, 2024
@matti-lamppu matti-lamppu self-assigned this Sep 19, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review September 19, 2024 05:37
@matti-lamppu matti-lamppu force-pushed the migrate-resources branch 3 times, most recently from c353bd3 to 664e29f Compare September 19, 2024 06:23
ranta
ranta reviewed Sep 23, 2024
View reviewed changes
locale/sv/LC_MESSAGES/django.po Outdated
Comment on lines 2219 to +2229
#: reservation_units/models/reservation_unit.py
#, fuzzy
#| msgid "Reservation for %(name)s"
msgid "Reservation Unit"
msgstr ""
msgstr "Plural-Forms: nplurals=2; plural=(n != 1);\n"

#: reservation_units/models/reservation_unit.py
#, fuzzy
#| msgid "Reservation for %(name)s"
msgid "Reservation Units"
msgstr ""
msgstr "Plural-Forms: nplurals=2; plural=(n != 1);\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuzzy translations

@matti-lamppu matti-lamppu changed the title Migrate resource to the new app [2.4] Migrate resource to the new app Sep 27, 2024
@matti-lamppu matti-lamppu changed the title [2.4] Migrate resource to the new app [2.4] Migrate resource models to the new app Sep 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from migrate-merchants to migrate-users-first October 1, 2024 14:32
@matti-lamppu matti-lamppu merged commit 3e41b17 into migrate-users-first Oct 1, 2024
6 checks passed
@matti-lamppu matti-lamppu deleted the migrate-resources branch October 1, 2024 14:32
@matti-lamppu matti-lamppu mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta left review comments

@vergama vergama vergama approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
refactor Refactors something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta