Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor backend pricing changes #1458

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Refactor backend pricing changes #1458

merged 2 commits into from
Oct 25, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Oct 18, 2024 •
edited
Loading

🛠️ Changelog

🧪 Test plan

  • Manual testing: admin-ui Saving existing and new reservation units should work as before, especially pricing.
  • Automated testing: ui utility functions for getting current / future price.

🎫 Tickets

@joonatank joonatank force-pushed the refactor-backend-pricing-changes branch 4 times, most recently from 30b5115 to 4468ccd Compare October 18, 2024 13:07
@joonatank joonatank marked this pull request as ready for review October 18, 2024 13:13
@joonatank joonatank force-pushed the refactor-backend-pricing-changes branch 3 times, most recently from 3659487 to 0ae0ea0 Compare October 24, 2024 11:11
joonatank
joonatank commented Oct 24, 2024
View reviewed changes
apps/admin-ui/src/spa/ReservationUnit/edit/form.ts Outdated Show resolved Hide resolved
apps/admin-ui/src/spa/ReservationUnit/edit/form.ts Outdated Show resolved Hide resolved
apps/admin-ui/src/spa/ReservationUnit/edit/form.ts Outdated Show resolved Hide resolved
apps/admin-ui/src/spa/ReservationUnit/edit/index.tsx Outdated Show resolved Hide resolved
apps/admin-ui/src/spa/ReservationUnit/edit/index.tsx Outdated Show resolved Hide resolved
apps/ui/modules/reservationUnit.ts Outdated Show resolved Hide resolved
apps/ui/modules/reservationUnit.ts Outdated Show resolved Hide resolved
apps/ui/modules/reservationUnit.ts Outdated Show resolved Hide resolved
apps/ui/pages/reservation-unit/[id].tsx Outdated Show resolved Hide resolved
packages/common/src/components/form/ControlledNumberInput.tsx Outdated Show resolved Hide resolved
vincit-matu
vincit-matu approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - but check commented stuff 👍

@joonatank joonatank force-pushed the refactor-backend-pricing-changes branch 3 times, most recently from aa76475 to 16e1cb7 Compare October 25, 2024 05:37
@joonatank joonatank force-pushed the refactor-backend-pricing-changes branch from 16e1cb7 to d2a6513 Compare October 25, 2024 05:37
@joonatank joonatank merged commit e73d0a4 into main Oct 25, 2024
8 checks passed
@joonatank joonatank deleted the refactor-backend-pricing-changes branch October 25, 2024 10:47
@joonatank joonatank mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu