Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-812 | E2E tests for submitting applications manually from handler UI #2149

Closed
wants to merge 7 commits into from
Closed

HL-812 | E2E tests for submitting applications manually from handler UI #2149

wants to merge 7 commits into from

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Jun 30, 2023 •
edited
Loading

Description ✨

Rebased from develop -> nginx-quality-of-life -> next-serve-https. I'll merge these before applying HL-812!

Tests are currently filling all the mandatory fields. All of the other combinations have been left unfilled (= hidden fields behind radio button = true state). The test fails because build version crashes on form submit (HL-864).

NOTE:

  • I've run tests with TestCafe 3.0.1 (1.x.x won't work with MacOS Ventura)
    • Be sure to include --experimental-proxyless with TestCafe if using newer version
  • I've run tests by using yarn bf-hdlr:start (build version of the app) on port 3100 with HTTPS on
    • You can get the certs from local-proxy container at /etc/nginx/localhost.key and /etc/nginx/localhost.crt
  • I've run tests by using compose.benefit-backend.yml (backend container only)

@sirtawast
feat: introduce upstream in location; add custom 502 page
c4ba470 
Missing upstream would no longer crash nginx and as a side-effect, kill the whole container
@sirtawast
feat: run benefit with backend only
1c852a8 
Allows for running the server on localhost with ports 3000 and 3100
@sirtawast
fix: rename Talpa CSV headers
4457c9b
@sirtawast
feat: add env var to run next build using HTTPS without proxy
6083b3f
@sirtawast
fix: clean up tests
53744b8
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #2149 (4e4aa5c) into develop (1f1ad98) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2149      +/-   ##
===========================================
- Coverage    27.81%   27.71%   -0.10%     
===========================================
  Files          766      767       +1     
  Lines        14878    14928      +50     
  Branches      3003     3003              
===========================================
  Hits          4138     4138              
- Misses       10263    10313      +50     
  Partials       477      477
Files Changed Coverage Δ
...it/handler/browser-tests/page-model/MainIngress.ts 0.00% <ø> (ø)
...ndler/browser-tests/pages/applications.testcafe.ts 0.00% <0.00%> (ø)
...it/handler/browser-tests/pages/archive.testcafe.ts 0.00% <0.00%> (ø)
...er/browser-tests/pages/new-application.testcafe.ts 0.00% <0.00%> (ø)
...fit/handler/browser-tests/pages/single.testcafe.ts 0.00% <ø> (ø)
...benefit/handler/browser-tests/utils/handlerUser.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2149.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2149.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-admn is deployed to: https://te-admn-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-yout is deployed to: https://te-yout-2149.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2149.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

te-bknd is deployed to: https://te-bknd-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-yout-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-admn-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2149.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2149.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

ks-hdlr is deployed to: https://ks-hdlr-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-empl is deployed to: https://ks-empl-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-youth is deployed to: https://ks-youth-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-bknd is deployed to: https://ks-bknd-2149.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-handler-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-empl-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-youth-2149.test.kuva.hel.ninja! 😆🎉🎉🎉

@sirtawast sirtawast changed the title HL-812 | HL-812 | E2E test for submitting applications manually from handler UI Jun 30, 2023
@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2149.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2149.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2149.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2149.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2149.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast changed the base branch from develop to main August 28, 2023 07:57
@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2149.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2149.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2149.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2149.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh-kesaseteli-api] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 1 Bug
Vulnerability E 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2149.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2149.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.3% 86.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2149.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2149.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2149.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt closed this Sep 27, 2023
@sirtawast sirtawast deleted the hl-812 branch October 25, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @codecov-commenter @terovirtanen @mjturt