Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-882 | Add new messenger style and fix translations on handler side #2167

Merged
merged 3 commits into from
Aug 11, 2023
Merged

HL-882 | Add new messenger style and fix translations on handler side #2167

merged 3 commits into from
Aug 11, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Aug 8, 2023 •
edited
Loading

Description ✨

  • New style of messenger with own chat bubbles on the right hand side and other person's bubbles on the left
    • Defaults to old style so TET and KS is not affected by the change
  • Add missing translations
image

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2167.api.dev.hel.ninja/healthz 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2167.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2167.test.kuva.hel.ninja 🚀🚀🚀

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #2167 (59d253f) into develop (8b65e8d) will increase coverage by 2.22%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2167      +/-   ##
===========================================
+ Coverage    27.73%   29.96%   +2.22%     
===========================================
  Files          759      816      +57     
  Lines        15492    16796    +1304     
  Branches      3457     3655     +198     
===========================================
+ Hits          4297     5033     +736     
- Misses       10624    11146     +522     
- Partials       571      617      +46
Files Changed Coverage Δ
...it/applicant/src/components/messenger/Messages.tsx 0.00% <ø> (ø)
...efit/handler/src/components/messenger/Messages.tsx 0.00% <ø> (ø)
...ontend/shared/src/components/messaging/Message.tsx 0.00% <0.00%> (ø)
...d/shared/src/components/messaging/Messaging.sc.tsx 0.00% <0.00%> (ø)

... and 57 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

ks-youth is deployed to: https://ks-youth-2167.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2167.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

ks-hdlr is deployed to: https://ks-hdlr-2167.test.kuva.hel.ninja 🚀🚀🚀

@sirtawast sirtawast changed the title Hl 882 HL-882 | Add new messenger style and fix translations on handler side Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

ks-empl is deployed to: https://ks-empl-2167.test.kuva.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sirtawast sirtawast requested a review from mjturt August 8, 2023 12:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

ks-bknd is deployed to: https://ks-bknd-2167.test.kuva.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.7% 84.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 60 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://helsinkibenefit-bf-appl-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2167.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://ks-handler-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2167.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2167.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

te-admn is deployed to: https://te-admn-2167.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

te-yout is deployed to: https://te-yout-2167.test.kuva.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

te-bknd is deployed to: https://te-bknd-2167.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://ks-empl-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://te-admn-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://te-yout-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2167.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2167.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2167.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2167.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

TestCafe result is success for https://ks-youth-2167.test.kuva.hel.ninja! 😆🎉🎉🎉

@sirtawast sirtawast requested a review from rikuke August 10, 2023 06:34
@sirtawast sirtawast merged commit bb7c79b into develop Aug 11, 2023
116 checks passed
@sirtawast sirtawast deleted the hl-882 branch August 11, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @terovirtanen @codecov-commenter @mjturt