Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-885 | Fix de minimis aid's row deletion #2169

Merged
merged 2 commits into from
Aug 22, 2023
Merged

HL-885 | Fix de minimis aid's row deletion #2169

merged 2 commits into from
Aug 22, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Aug 10, 2023 •
edited
Loading

Description ✨

De minimis aid could not be removed (one aid had to remain, otherwise the rows would not get updated) after application was created. Now additional checks are being done:

  • Ensure there is no unfinished aid fields
    • Toast an error if there is
  • If there is no aid rows but de minimis toggle radio is on then consider radio is off

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2169.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2169.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2169.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2169.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2169.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2169.dev.hel.ninja 🚀🚀🚀

@sirtawast sirtawast changed the title HL-885 | Fix deminimis deletion HL-885 | Fix de minimis aid's row deletion Aug 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #2169 (fa62b90) into develop (01ea28c) will decrease coverage by 12.19%.
Report is 31 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop    #2169       +/-   ##
============================================
- Coverage    29.98%   17.79%   -12.19%     
============================================
  Files          816      122      -694     
  Lines        16791     2944    -13847     
  Branches      3652      736     -2916     
============================================
- Hits          5034      524     -4510     
+ Misses       11140     2304     -8836     
+ Partials       617      116      -501
Files Changed Coverage Δ
...orms/application/deMinimisAid/DeMinimisAidForm.tsx 0.00% <0.00%> (ø)
...s/forms/application/step1/ApplicationFormStep1.tsx 0.00% <0.00%> (ø)
...forms/application/step1/useApplicationFormStep1.ts 0.00% <0.00%> (ø)

... and 695 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2169.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2169.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2169.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2169.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

[yjdh-helsinkilisa-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

[yjdh-helsinkilisa-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

[yjdh-helsinkilisa-applicant] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 58 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

[yjdh-helsinkilisa-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 4 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2169.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2169.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2169.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2169.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 34e3341 into develop Aug 22, 2023
64 checks passed
@sirtawast sirtawast deleted the hl-885 branch August 22, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

@mjturt mjturt Awaiting requested review from mjturt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @terovirtanen @codecov-commenter @rikuke