Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-642: Add approvals to review state #2175

Merged
merged 1 commit into from
Aug 18, 2023
Merged

HL-642: Add approvals to review state #2175

merged 1 commit into from
Aug 18, 2023

Conversation

mjturt
Copy link
Contributor

@mjturt mjturt commented Aug 16, 2023

Description ✨

Forgot approvals from review state before. Adding that now.

@mjturt mjturt changed the title HL-624: Add approvals to review state HL-642: Add approvals to review state Aug 16, 2023
@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2175.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2175.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2175.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2175.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2175.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2175.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

[yjdh-helsinkilisa-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

[yjdh-helsinkilisa-applicant] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 56 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

[yjdh-helsinkilisa-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 57 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

[yjdh-helsinkilisa-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 4 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2175.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2175.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2175.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2175.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt merged commit 0906362 into develop Aug 18, 2023
67 checks passed
@mjturt mjturt deleted the HL-642-handler-check-icons-2 branch August 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjturt @terovirtanen @sirtawast