Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: updating backend api to use platta version of linkedevents #2177

Closed
wants to merge 5 commits into from

Conversation

arpargo
Copy link
Contributor

@arpargo arpargo commented Aug 17, 2023

Description ✨

LinkedEvents old urls are going to stop working sooner or later so updating them to use the new environments that have been setup.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #2177 (742a4f7) into develop (34e3341) will increase coverage by 22.27%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##           develop    #2177       +/-   ##
============================================
+ Coverage    27.85%   50.13%   +22.27%     
============================================
  Files          764      168      -596     
  Lines        14850     2557    -12293     
  Branches      2992      393     -2599     
============================================
- Hits          4137     1282     -2855     
+ Misses       10239     1223     -9016     
+ Partials       474       52      -422     
Files Changed Coverage Δ
...nd/tet/shared/src/backend-api/linked-events-api.ts 0.00% <0.00%> (ø)
...rontend/tet/youth/browser-tests/search.testcafe.ts 0.00% <ø> (ø)
...admin/src/__tests__/utils/backend/backend-nocks.ts 82.35% <60.00%> (+0.53%) ⬆️
frontend/tet/youth/src/backend-api/backend-api.ts 72.72% <100.00%> (ø)

... and 596 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

te-yout is deployed to: https://te-yout-2177.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-admn is deployed to: https://te-admn-2177.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-bknd is deployed to: https://te-bknd-2177.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-admn-2177.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-yout-2177.test.kuva.hel.ninja! 😆🎉🎉🎉

Copy link
Collaborator

@sirtawast sirtawast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents: could use a constant. linkedevents-api-dev.agw.arodevtest.hel.fi is defined 39 (py) + 4 (ts) times.

@arpargo
Copy link
Contributor Author

arpargo commented Aug 18, 2023

My two cents: could use a constant. linkedevents-api-dev.agw.arodevtest.hel.fi is defined 39 (py) + 4 (ts) times.

This is true, but most of the mentions are inside test json payloads used for tests and I'd rather not try to poke around those to parametrize them.

Anyways, found some i could fix and found few missed urls.

Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sirtawast sirtawast changed the base branch from develop to main August 28, 2023 08:02
@tuomas777 tuomas777 self-requested a review October 11, 2023 08:50
@tuomas777
Copy link
Contributor

Actually the URL needs to be changed one more time, so let's not merge this yet 😅

@arpargo
Copy link
Contributor Author

arpargo commented Oct 11, 2023

Actually the URL needs to be changed one more time, so let's not merge this yet 😅

Didn't we actually just change the new platta urls to match the old urls so this PR is unnecessary?

@tuomas777
Copy link
Contributor

Superseded by #2339

@tuomas777 tuomas777 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants