-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: updating backend api to use platta version of linkedevents #2177
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2177 +/- ##
============================================
+ Coverage 27.85% 50.13% +22.27%
============================================
Files 764 168 -596
Lines 14850 2557 -12293
Branches 2992 393 -2599
============================================
- Hits 4137 1282 -2855
+ Misses 10239 1223 -9016
+ Partials 474 52 -422
... and 596 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
te-yout is deployed to: https://te-yout-2177.test.kuva.hel.ninja 🚀🚀🚀 |
te-admn is deployed to: https://te-admn-2177.test.kuva.hel.ninja 🚀🚀🚀 |
te-bknd is deployed to: https://te-bknd-2177.test.kuva.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://te-admn-2177.test.kuva.hel.ninja! 😆🎉🎉🎉 |
TestCafe result is success for https://te-yout-2177.test.kuva.hel.ninja! 😆🎉🎉🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents: could use a constant. linkedevents-api-dev.agw.arodevtest.hel.fi
is defined 39 (py) + 4 (ts) times.
This is true, but most of the mentions are inside test json payloads used for tests and I'd rather not try to poke around those to parametrize them. Anyways, found some i could fix and found few missed urls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Actually the URL needs to be changed one more time, so let's not merge this yet 😅 |
Didn't we actually just change the new platta urls to match the old urls so this PR is unnecessary? |
Superseded by #2339 |
Description ✨
LinkedEvents old urls are going to stop working sooner or later so updating them to use the new environments that have been setup.