Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-891: Fix CSRF token issues #2182

Merged
merged 6 commits into from
Aug 22, 2023
Merged

HL-891: Fix CSRF token issues #2182

merged 6 commits into from
Aug 22, 2023

Conversation

mjturt
Copy link
Contributor

@mjturt mjturt commented Aug 21, 2023

Description ✨

Using /me endpoint to deliver the CSRF token and saving it to browsers local storage.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #2182 (cc4f2d7) into develop (002d87a) will decrease coverage by 8.13%.
The diff coverage is 5.55%.

@@             Coverage Diff             @@
##           develop    #2182      +/-   ##
===========================================
- Coverage    30.15%   22.03%   -8.13%     
===========================================
  Files          822      484     -338     
  Lines        16158     9204    -6954     
  Branches      3190     1868    -1322     
===========================================
- Hits          4873     2028    -2845     
+ Misses       10765     6880    -3885     
+ Partials       520      296     -224
Files Changed Coverage Δ
frontend/benefit/handler/src/hooks/useUserQuery.ts 0.00% <0.00%> (ø)
...tend/shared/src/backend-api/BackendAPIProvider.tsx 0.00% <0.00%> (ø)
frontend/shared/src/utils/localstorage.utils.ts 0.00% <0.00%> (ø)
frontend/benefit/handler/src/constants.ts 100.00% <100.00%> (ø)

... and 339 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

te-bknd is deployed to: https://te-bknd-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-bknd is deployed to: https://ks-bknd-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-hdlr is deployed to: https://ks-hdlr-2182.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2182.api.dev.hel.ninja/healthz 🚀🚀🚀

@github-actions
Copy link
Contributor

te-admn is deployed to: https://te-admn-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-empl is deployed to: https://ks-empl-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-youth is deployed to: https://ks-youth-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-yout is deployed to: https://te-yout-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2182.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-yout-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-admn-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-handler-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2182.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2182.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-empl-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2182.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-youth-2182.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2182.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2182.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast self-requested a review August 22, 2023 12:29
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2182.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2182.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2182.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.3% 86.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2182.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2182.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2182.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt merged commit 8ca325a into develop Aug 22, 2023
164 checks passed
@mjturt mjturt deleted the HL-891-csrf-token branch August 22, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjturt @codecov-commenter @terovirtanen @sirtawast