Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Next12 builds - Remove TS things from JS config file #2183

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix Next12 builds - Remove TS things from JS config file #2183

merged 1 commit into from
Aug 22, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Aug 22, 2023 •
edited
Loading

Description ✨

Issue with TS/JS in devops build phase. Sentry seems to spin up with the service now on localhost at least.

@sirtawast sirtawast changed the title remove TS things from JS file Remove TS things from JS config file Aug 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #2183 (1dfe2e6) into develop (15481ef) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2183      +/-   ##
===========================================
+ Coverage    30.00%   30.15%   +0.15%     
===========================================
  Files          821      822       +1     
  Lines        16149    16158       +9     
  Branches      3187     3190       +3     
===========================================
+ Hits          4845     4873      +28     
+ Misses       10784    10765      -19     
  Partials       520      520
Files Changed Coverage Δ
frontend/shared/sentry-config.js 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2183.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2183.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-admn is deployed to: https://te-admn-2183.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2183.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-youth is deployed to: https://ks-youth-2183.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-hdlr is deployed to: https://ks-hdlr-2183.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2183.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-yout is deployed to: https://te-yout-2183.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2183.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2183.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-empl is deployed to: https://ks-empl-2183.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2183.api.dev.hel.ninja/healthz 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2183.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-bknd is deployed to: https://te-bknd-2183.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2183.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

ks-bknd is deployed to: https://ks-bknd-2183.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2183.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.8% 84.8% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-handler-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://helsinkibenefit-bf-appl-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-yout-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-admn-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-empl-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe employer result is failed for https://kesaseteli-pr2183.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2183.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2183.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2183.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-youth-2183.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2183.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast changed the title Remove TS things from JS config file Fix Next12 builds part 1/x - Remove TS things from JS config file Aug 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@sirtawast sirtawast merged commit 002d87a into develop Aug 22, 2023
164 checks passed
@sirtawast sirtawast deleted the hotfix-next12 branch August 22, 2023 14:06
@sirtawast sirtawast changed the title Fix Next12 builds part 1/x - Remove TS things from JS config file Fix Next12 builds - Remove TS things from JS config file Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@rikuke rikuke Awaiting requested review from rikuke

@karisal-anders karisal-anders Awaiting requested review from karisal-anders

@JanneJuhola JanneJuhola Awaiting requested review from JanneJuhola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @codecov-commenter @terovirtanen @mjturt